Address PR feedback: health catches non-API errors; isort imports; packaging version test; sandbox and transport tests.

Author: eddietejeda

hotdata_runtime/__init__.py

@@ -3,7 +3,6 @@
 from importlib.metadata import PackageNotFoundError, version
 
 from hotdata_runtime.client import HotdataClient, from_env
-from hotdata_runtime.health import workspace_health_lines
 from hotdata_runtime.env import (
     default_api_key,
     default_host,
@@ -13,6 +12,7 @@
     normalize_host,
     pick_workspace,
 )
+from hotdata_runtime.health import workspace_health_lines
 from hotdata_runtime.result import QueryResult
 
 try:

hotdata_runtime/health.py

@@ -23,3 +23,5 @@ def workspace_health_lines(client: HotdataClient) -> tuple[bool, list[str]]:
         return True, lines
     except ApiException as e:
         return False, [e.reason or str(e)]
+    except Exception as e:
+        return False, [str(e)]

pyproject.toml

@@ -16,6 +16,7 @@ dependencies = [
 
 [dependency-groups]
 dev = [
+  "packaging>=23",
   "pytest>=8.0",
 ]
 

tests/test_health.py

@@ -22,6 +22,22 @@ def list_connections(self):
     assert any("reachable" in p for p in parts)
 
 
+def test_workspace_health_ok_includes_sandbox_when_session_set():
+    client = HotdataClient(
+        "k", "ws", host="https://api.hotdata.dev", session_id="sb_test"
+    )
+    listing = type("L", (), {"connections": [object()]})()
+
+    class FakeConnectionsApi:
+        def list_connections(self):
+            return listing
+
+    with patch.object(client, "connections", return_value=FakeConnectionsApi()):
+        ok, parts = workspace_health_lines(client)
+    assert ok is True
+    assert any("sandbox" in p and "sb_test" in p for p in parts)
+
+
 def test_workspace_health_api_error():
     client = HotdataClient("k", "ws", host="https://api.hotdata.dev")
 
@@ -33,3 +49,16 @@ def list_connections(self):
         ok, parts = workspace_health_lines(client)
     assert ok is False
     assert parts == ["nope"]
+
+
+def test_workspace_health_non_api_error():
+    client = HotdataClient("k", "ws", host="https://api.hotdata.dev")
+
+    class Boom:
+        def list_connections(self):
+            raise OSError("connection refused")
+
+    with patch.object(client, "connections", return_value=Boom()):
+        ok, parts = workspace_health_lines(client)
+    assert ok is False
+    assert parts == ["connection refused"]

tests/test_version.py

@@ -1,12 +1,12 @@
-import re
-
 from importlib.metadata import version as dist_version
 
+from packaging.version import Version
+
 import hotdata_runtime as hr
 
 
-def test_version_is_pep440_core():
-    assert re.fullmatch(r"\d+\.\d+\.\d+(\+.*)?", hr.__version__)
+def test_version_is_valid_pep440():
+    Version(hr.__version__)
 
 
 def test_version_matches_distribution_metadata():