Skip to content

Commit c8ad74a

Browse files
authored
ci: don't gate regen PR on cargo check/test (#49)
1 parent d8502d9 commit c8ad74a

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/regenerate.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -174,13 +174,13 @@ jobs:
174174
fi
175175
echo "Ergonomic layer survived regeneration: hand-written modules, lib.rs wiring, and JWT/bearer + debug-logging hooks all intact."
176176
177-
# cargo check is the template-drift tripwire. --all-features compiles the
178-
# optional arrow surface too. The --no-run test build catches breakage in
179-
# the integration tests that target the generated apis.
180-
- name: Verify generated client compiles
181-
run: |
182-
cargo check --all-features
183-
cargo test --all-features --no-run
177+
# NOTE: regeneration deliberately does NOT compile the crate. A compile
178+
# failure here used to abort the job before "Create PR", so a regen that
179+
# produced valid-but-not-yet-wired output (e.g. a spec change that orphans
180+
# part of the hand-written ergonomic layer) failed silently with no PR to
181+
# act on. The PR is the artifact we want: integration-tests.yml runs
182+
# `cargo test --all-features` on every PR to main, so any breakage shows
183+
# up loudly as red CI on the filed PR instead of a buried workflow run.
184184

185185
# Soft parity warning: surface scenarios that still lack a tests/<name>.rs.
186186
# Non-fatal during the per-scenario rollout (rust is exempt until its tests

0 commit comments

Comments
 (0)