ci: don't gate regen PR on cargo check/test#49
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verified: the regen PR is created with the GitHub App token (not the default GITHUB_TOKEN), so it does trigger integration-tests.yml on pull_request: [main] — the change's premise holds. That job's cargo test --all-features --test '*' compiles the lib + integration targets under all features, preserving the compile coverage dropped here, and the regen-safety guard for the ergonomic layer / auth + logging hooks still runs. Trade-off (PR-as-artifact over silent abort) is sound and well documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regeneration aborted before
Create PRwhenever the generated crate didn't compile, so a regen that orphaned part of the hand-written ergonomic layer (e.g. the sandbox removal) failed silently with no PR to act on. Drops thecargo check/cargo test --no-runstep —integration-tests.ymlalready runscargo test --all-featureson every PR to main, so breakage now surfaces as red CI on the filed PR instead of a buried workflow run. The grep-based regen-safety guard (ergonomic layer / auth + logging hooks) stays.