Skip to content

Hide native title when HTML <title> is not present or blank #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonvogt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hide native title when HTML <title> is not present or blank #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ...on-fragments/src/main/java/dev/hotwire/navigation/fragments/HotwireWebFragmentDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,19 @@ internal class HotwireWebFragmentDelegate(
}

private fun title(): String {
return webView.title ?: ""
}
val title = webView.title.orEmpty()
val url = webView.url.orEmpty()
return if (title.isEmpty() || title.asDisplayUrl() == url.asDisplayUrl()) "" else title
}

// Android's WebView uses the URL when a page has no <title>:
// Normalize the URL and compare it to the title. If they are the same,
// return an empty string to avoid showing the URL as the title.
private fun String.asDisplayUrl(): String =
substringAfter("://")
.removePrefix("www.")
.replace("%20", " ")
.trimEnd('/')
Comment on lines +392 to +395

@leonvogt leonvogt Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First I had a simpler check, but the problem is that, webView.url contains the schema while webView.title doesnt':

webView.url = http://192.168.42.51:3000/dashboard
webView.title = 192.168.42.51:3000/dashboard

To also handle the case of www.domain.com sites, we we normalize both strings the same way before comparing them.


private fun registerFileChooserLauncher(): ActivityResultLauncher<Intent> {
return navDestination.fragment.registerForActivityResult(StartActivityForResult()) { result ->
Expand Down
Loading