Skip to content

Fix crash on non-HTTP scheme links #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbarta merged 2 commits into from
Jul 27, 2026
+14 −1
Merged

Fix crash on non-HTTP scheme links #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
819b686
Fix crash on non-HTTP scheme links
leonvogt Jul 24, 2026
011afcb
Add test coverage for non-HTTP scheme locations
mbarta Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/src/main/kotlin/dev/hotwire/core/turbo/config/PathConfigurationData.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package dev.hotwire.core.turbo.config

import com.google.gson.annotations.SerializedName
import java.net.MalformedURLException
import java.net.URL

@ConsistentCopyVisibility
Expand Down Expand Up @@ -36,7 +37,11 @@ data class PathConfigurationData internal constructor(
}

private fun path(location: String): String {
val url = URL(location)
val url = try {
URL(location)
} catch (e: MalformedURLException) {
return ""
}

return if (url.query == null) {
url.path
Expand Down
8 changes: 8 additions & 0 deletions core/src/test/kotlin/dev/hotwire/core/turbo/config/PathConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,14 @@ class PathConfigurationTest : BaseRepositoryTest() {
assertThat(pathConfiguration.properties("$url/new").pullToRefreshEnabled).isFalse
}

@Test
fun unknownSchemeLocationDoesNotThrow() {
assertThat(pathConfiguration.properties("mailto:test@example.com")).isNotNull
assertThat(pathConfiguration.properties("tel:+15551234567")).isNotNull
assertThat(pathConfiguration.properties("sms:+15551234567")).isNotNull
assertThat(pathConfiguration.properties("custom-app://feature")).isNotNull
}

@Test
fun customProperties() {
assertThat((pathConfiguration.properties("$url/custom/tabs").getTabs()?.size)).isEqualTo(1)
Expand Down
Loading