add categories for break ideas#1669
Conversation
|
I like the direction here — adding structure to break ideas makes a lot of sense. Before getting into implementation details, I stepped back and thought about how I’d approach this if I were designing it from scratch. To me, break ideas feel more like content than general application settings. So, I’d probably think in terms of:
In that model, messages would be structured objects with category metadata, and managed somewhat independently from the rest of the app configuration. Given where things are today, it seems like we can still move toward something like this incrementally. One idea would be to introduce a small abstraction for loading break ideas instead of reading them directly from settings. That would make it easier to:
I’m fully on board with adding categories — this just seems like a way to make the change easier to extend and maintain over time. Curious how you’re thinking about it, or if you have a different approach in mind. |
Issue: #1596
Requirements
nodeversion specified inpackage.jsonwas used (ie using nvm).npm install --no-save).npm run lintreports no offenses.npm run testis error-free.Description of the Change
As first step, I added 7 categories as proposed in #1596 (comment)
I'd suggest to use the idea ID's prefix to identify the category, as this makes handling the ideas easier and we don't need to maintain an additional prop for the category.
Next step would be to improve IdeasLoader & Shuffed
Verification Process
Other information