Skip to content

Commit 5e73831

Browse files
Copilotneilime
andcommitted
Fix code review feedback and formatting
Co-authored-by: neilime <314088+neilime@users.noreply.github.com>
1 parent 01ef37e commit 5e73831

3 files changed

Lines changed: 10 additions & 15 deletions

File tree

actions/parse-ci-reports/src/ReportPathResolver.test.js

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,7 @@ describe("ReportPathResolver", () => {
9292
"**/*.tap",
9393
];
9494
for (const pattern of testPatterns) {
95-
assert.ok(
96-
patterns.includes(pattern),
97-
`Missing test pattern: ${pattern}`,
98-
);
95+
assert.ok(patterns.includes(pattern), `Missing test pattern: ${pattern}`);
9996
}
10097

10198
// Verify coverage patterns are included (from LCOVParser and CoberturaParser)
@@ -148,10 +145,7 @@ describe("ReportPathResolver", () => {
148145
"**/astro-check-report.txt",
149146
];
150147
for (const pattern of lintPatterns) {
151-
assert.ok(
152-
patterns.includes(pattern),
153-
`Missing lint pattern: ${pattern}`,
154-
);
148+
assert.ok(patterns.includes(pattern), `Missing lint pattern: ${pattern}`);
155149
}
156150

157151
// All test patterns should be included
@@ -163,10 +157,7 @@ describe("ReportPathResolver", () => {
163157
"**/*.tap",
164158
];
165159
for (const pattern of testPatterns) {
166-
assert.ok(
167-
patterns.includes(pattern),
168-
`Missing test pattern: ${pattern}`,
169-
);
160+
assert.ok(patterns.includes(pattern), `Missing test pattern: ${pattern}`);
170161
}
171162

172163
// All coverage patterns should be included

actions/parse-ci-reports/src/parsers/BaseParser.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ export class BaseParser {
5555
* @returns {string[]} Array of glob patterns
5656
*/
5757
getAutoPatterns() {
58-
return [];
58+
throw new Error("getAutoPatterns() must be implemented by subclass");
5959
}
6060
}

actions/parse-ci-reports/src/parsers/ParserFactory.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,15 @@ export class ParserFactory {
9797
*/
9898
getAutoPatternsMap() {
9999
return {
100-
[ReportCategory.TEST]: this.getAutoPatternsByCategory(ReportCategory.TEST),
100+
[ReportCategory.TEST]: this.getAutoPatternsByCategory(
101+
ReportCategory.TEST,
102+
),
101103
[ReportCategory.COVERAGE]: this.getAutoPatternsByCategory(
102104
ReportCategory.COVERAGE,
103105
),
104-
[ReportCategory.LINT]: this.getAutoPatternsByCategory(ReportCategory.LINT),
106+
[ReportCategory.LINT]: this.getAutoPatternsByCategory(
107+
ReportCategory.LINT,
108+
),
105109
};
106110
}
107111
}

0 commit comments

Comments
 (0)