Skip to content

fix(actions/docker/create-images-manifests): prevent failure on registry propagation timing issue #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilime merged 1 commit into from
Jun 10, 2026
Merged

fix(actions/docker/create-images-manifests): prevent failure on registry propagation timing issue #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 39 additions & 18 deletions actions/docker/create-images-manifests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,30 +131,51 @@ runs:
}
}

// Helper function to build annotations options
function buildAnnotationsOption(annotations) {
const annotationLevels = ["index"];
return Object.keys(annotations)
.map(annotation => annotationLevels
.map(annotationLevel => `--annotation "${annotationLevel}:${annotation}=${annotations[annotation]}"`)
)
.flat()
.join(" ");
}

// Helper function to create multiarch manifest
async function createMultiarchManifest(builtImage, imagesWithTags) {
const platformsOption = builtImage.platforms.map(platform => `--platform ${platform}`).join(" ");
const tagsOption = imagesWithTags.map(image => `--tag ${image}`).join(" ");
const sources = builtImage.images.join(" ");
const annotationsOption = buildAnnotationsOption(builtImage.annotations);
const platformArgs = builtImage.platforms.flatMap(platform => ["--platform", platform]);
const tagArgs = imagesWithTags.flatMap(image => ["--tag", image]);
const annotationArgs = Object.keys(builtImage.annotations).flatMap(key => [
"--annotation",
`index:${key}=${builtImage.annotations[key]}`,
]);
const sourceArgs = builtImage.images;

const createManifestArgs = [
"buildx", "imagetools", "create",
...platformArgs,
...annotationArgs,
...tagArgs,
...sourceArgs,
];

const maxAttempts = 6;
const delayMs = 5000;

const createManifestCommand = `docker buildx imagetools create ${platformsOption} ${annotationsOption} ${tagsOption} ${sources}`;
for (let attempt = 1; attempt <= maxAttempts; attempt++) {
const result = await exec.getExecOutput("docker", createManifestArgs, { ignoreReturnCode: true });

if (result.exitCode === 0) {
core.debug(`Create manifest for "${builtImage.name}" executed`);
builtImage.images = imagesWithTags;
return;
}

await exec.exec(createManifestCommand);
core.debug(`Create manifest for "${builtImage.name}" ("${createManifestCommand}") executed`);
const commandOutput = `${result.stderr || ""}\n${result.stdout || ""}`.trim();
const isRetryableNotFound = /not found|manifest unknown|no such manifest/i.test(commandOutput);

builtImage.images = imagesWithTags;
if (!isRetryableNotFound || attempt === maxAttempts) {
throw new Error(
`Failed to create manifest for "${builtImage.name}" (attempt ${attempt}/${maxAttempts}, exit code: ${result.exitCode}).\n${commandOutput}`,
);
}

core.warning(
`Source manifest for "${builtImage.name}" not yet available (attempt ${attempt}/${maxAttempts}). Retrying in ${delayMs}ms...`,
);
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

// Helper function to build image tags
Expand Down
Loading