chore: better testing with ct and fix for HK ci

Author: fredleger

codespace-like/ci/persistence-values.yaml

@@ -1,3 +1,2 @@
 persistence:
-  storageClass: dummy
   size: 1Gi

codespace-like/templates/deployment.yaml

@@ -44,6 +44,8 @@ spec:
             {{- toYaml .Values.livenessProbe | nindent 12 }}
           readinessProbe:
             {{- toYaml .Values.readinessProbe | nindent 12 }}
+          startupProbe:
+            {{- toYaml .Values.startupProbe | nindent 12 }}
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
           volumeMounts:

codespace-like/templates/tests/test-connection.yaml

@@ -10,6 +10,11 @@ spec:
   containers:
     - name: wget
       image: busybox
-      command: ['wget']
-      args: ['{{ include "codespace-like.fullname" . }}:{{ .Values.service.port }}']
+      command:
+        - 'wget'
+        - -q
+        - -O
+        - '/dev/null'
+      args:
+        - http://{{ include "codespace-like.fullname" . }}:{{ .Values.service.port }}/healthz
   restartPolicy: Never

codespace-like/values.schema.json

@@ -61,7 +61,7 @@
           "type": "string"
         },
         "repository": {
-          "default": "webofmars/codespace-like",
+          "default": "ghcr.io/hoverkraft-tech/docker-base-images/codespace-like",
           "title": "repository",
           "type": "string"
         },
@@ -182,7 +182,7 @@
           "additionalProperties": false,
           "properties": {
             "path": {
-              "default": "/",
+              "default": "/healthz",
               "title": "path",
               "type": "string"
             },
@@ -211,6 +211,12 @@
       "title": "nameOverride",
       "type": "string"
     },
+    "namespace": {
+      "default": "~",
+      "description": "FIXME: this is for compatibility with hoverkraft CI\n       see https://github.com/hoverkraft-tech/ci-github-container/issues/815",
+      "title": "namespace",
+      "type": "null"
+    },
     "nodeSelector": {
       "additionalProperties": false,
       "required": [],
@@ -269,7 +275,7 @@
           "additionalProperties": false,
           "properties": {
             "path": {
-              "default": "/",
+              "default": "/healthz",
               "title": "path",
               "type": "string"
             },
@@ -369,6 +375,37 @@
       "title": "serviceAccount",
       "type": "object"
     },
+    "startupProbe": {
+      "additionalProperties": false,
+      "properties": {
+        "httpGet": {
+          "additionalProperties": false,
+          "properties": {
+            "path": {
+              "default": "/healthz",
+              "title": "path",
+              "type": "string"
+            },
+            "port": {
+              "default": "http",
+              "title": "port",
+              "type": "string"
+            }
+          },
+          "required": [
+            "path",
+            "port"
+          ],
+          "title": "httpGet",
+          "type": "object"
+        }
+      },
+      "required": [
+        "httpGet"
+      ],
+      "title": "startupProbe",
+      "type": "object"
+    },
     "tolerations": {
       "items": {
         "required": []
@@ -394,6 +431,7 @@
     }
   },
   "required": [
+    "namespace",
     "replicaCount",
     "image",
     "imagePullSecrets",
@@ -409,6 +447,7 @@
     "resources",
     "livenessProbe",
     "readinessProbe",
+    "startupProbe",
     "autoscaling",
     "persistence",
     "volumes",

codespace-like/values.yaml

@@ -3,10 +3,14 @@
 # This is a YAML-formatted file.
 # Declare variables to be passed into your templates.
 
+# FIXME: this is for compatibility with hoverkraft CI
+#        see https://github.com/hoverkraft-tech/ci-github-container/issues/815
+namespace: ~
+
 replicaCount: 1
 
 image:
-  repository: webofmars/codespace-like
+  repository: ghcr.io/hoverkraft-tech/docker-base-images/codespace-like
   pullPolicy: IfNotPresent
   # Overrides the image tag whose default is the chart appVersion.
   tag: ""
@@ -76,11 +80,15 @@ resources: {}
 
 livenessProbe:
   httpGet:
-    path: /
+    path: /healthz
     port: http
 readinessProbe:
   httpGet:
-    path: /
+    path: /healthz
+    port: http
+startupProbe:
+  httpGet:
+    path: /healthz
     port: http
 
 autoscaling: