Skip to content

Commit b021285

Browse files
fredlegerCopilot
andauthored
chore: apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 27c739e commit b021285

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

aws/eks-addon/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# eks addons
22

3-
Deploy a single eks addon to an eks cluster.
4-
The main difference with the eks-addons module is thta this module give you more control over the addon,
5-
like setting the an IRSA role or an EKS pod identity role.
3+
Deploy a single EKS addon to an EKS cluster.
4+
The main difference from the eks-addons module is that this module gives you more control over the addon,
5+
such as configuring an IRSA role or an EKS pod identity role.
66

77
<!-- BEGIN_TF_DOCS -->
88
## Requirements
@@ -47,5 +47,5 @@ No modules.
4747

4848
| Name | Description |
4949
|------|-------------|
50-
| <a name="output_addon_arns"></a> [addon\_arns](#output\_addon\_arns) | The ARNs of the EKS addons |
50+
| <a name="output_addon_arn"></a> [addon\_arn](#output\_addon\_arn) | The ARN of the EKS addon |
5151
<!-- END_TF_DOCS -->

aws/eks-addon/eks-addon.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ resource "aws_eks_addon" "addon" {
44
cluster_name = var.cluster_name
55
configuration_values = var.configuration_values
66
resolve_conflicts = "OVERWRITE"
7-
service_account_role_arn = var.service_account_role_arn ? var.service_account_role_arn : null
7+
service_account_role_arn = var.service_account_role_arn != null && var.service_account_role_arn != "" ? var.service_account_role_arn : null
88
tags = local.interpolated_tags
99
}

aws/eks-addon/outputs.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
output "addon_arns" {
2-
description = "The ARNs of the EKS addons"
3-
value = aws_eks_addon.addon[*].arn
1+
output "addon_arn" {
2+
description = "The ARN of the EKS addon"
3+
value = aws_eks_addon.addon.arn
44
}

0 commit comments

Comments
 (0)