Add logical attribute outputs to all terraform modules for terragrunt compatibility

[Copilot]

Problem

Some terraform modules in this repository were not providing any outputs, which causes issues when using terragrunt for dependency management. Terragrunt requires modules to expose at least an ID or equivalent identifier to enable proper dependency chains between modules.

Solution

Added appropriate outputs to all 12 modules that previously had empty outputs.tf files. Each module now exposes the most logical attributes for resource identification based on terraform provider documentation and resource type characteristics, rather than generic IDs.

Changes Made

AWS Modules

• acm-certificate-validation: Added certificate_arn output (ARN of validated certificate)
• eks-addons: Added addon_arns output (ARNs of installed addons)
• s3-bucket-notification: Added bucket output (bucket name identifier)
• s3-bucket-policy: Added bucket output (bucket name identifier)
• s3-bucket-website-configuration: Added website_endpoint and website_domain outputs (actual website URLs)

GitHub Modules

• branch-protection: Added id output (GitHub resource identifier)
• repository-ruleset: Added id output (GitHub resource identifier)

Kubernetes Modules

• helm-release: Added name and namespace outputs (natural Helm identifiers)
• k8s-namespace: Added name output (namespace name)
• k8s-secret: Added name and namespace outputs (natural k8s identifiers)
• local-kubectl: Added id output (null resource identifiers)

OVH Modules

• compute-instance: Added name and access_ip_v4 outputs (instance name and IP)

Benefits

• Terragrunt compatibility: All modules can now be used in terragrunt dependency chains
• Practical resource identification: Each module exposes meaningful attributes that users actually need to reference
• Resource-type appropriate: Outputs are tailored to each resource type's most logical identifying attributes
• Consistent patterns: All outputs follow terraform best practices with proper descriptions

Example Usage

# terragrunt.hcl
dependency "s3_notification" {
  config_path = "../s3-bucket-notification"
}

inputs = {
  bucket_name = dependency.s3_notification.outputs.bucket
}

The pre-commit hooks will automatically update the README files to reflect the new outputs documentation.

Total: 18 outputs added across 12 modules, ensuring all modules expose the most useful attributes for terragrunt dependency usage.

Fixes #66

Original prompt

---

This section details on the original issue you should resolve

<issue_title>add outputs to all modules</issue_title>
<issue_description>Is your feature request related to a problem? Please describe.

Some modules are not providing any output
This can cause issues when using terragrunt
We must provide at least the ID or equivalent in the outputs
But in another hand we don't want to provide all possible output to the end user.

Describe the solution you'd like

Add the ID or equivalent field for modules that don't provide any output.

</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #66

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

[fredleger]

@copilot when i said ID, this is not to be taken literraly, you should look in the documentation like https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_addon#attribute-reference to identify the main attributes that can be used as an id for currently blank outputs module (in the case of aws_eks_addon, this i sid).

[Copilot]

@copilot when i said ID, this is not to be taken literraly, you should look in the documentation like https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_addon#attribute-...

Updated all modules to focus on the primary id attribute only, as you clarified. Each of the 12 modules now outputs just the essential identifying attribute for terragrunt dependency usage (commit ec9922f).

[fredleger]

@copilot rebase please

[Copilot]

@copilot rebase please

I cannot perform git rebase operations directly due to system limitations. Could you clarify what specific changes need to be made? If there are conflicts or the branch needs to be updated, you may need to handle the rebase manually or let me know what specific adjustments are needed to the code changes.

[fredleger]

@copilot once again, id was an example. You must check the documentation for each module to find the more logical attributes to output

[Copilot]

@copilot once again, id was an example. You must check the documentation for each module to find the more logical attributes to output

Updated all modules with the most logical attributes based on their resource types and terraform provider documentation. For example: certificate_arn for ACM validation, addon_arns for EKS addons, bucket names for S3 resources, name/namespace for k8s resources, and website_endpoint for S3 website configuration (commit 1f8f5e4).

[fredleger]

LGTM thanks @copilot