WIP: feat: add ovh gateway module#83
Merged
Merged
Conversation
30c390f to
fc745a8
Compare
fc745a8 to
df01901
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Terraform module for managing an OVH public cloud gateway, consistent with the existing OVH PCI module structure in this repository.
Changes:
- Adds a new
ovh/gatewayTerraform module with variables, provider configuration, main locals, and the OVH gateway resource. - Exposes the created gateway’s ID via an output for use by consumers.
- Documents the new module in a README generated with terraform-docs (structure aligned with other OVH modules, though currently with some formatting issues).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ovh/gateway/variables.tf |
Defines common module inputs (name, customer, tags) plus gateway-specific inputs (cloud_project_id, model, region, network_uuid, subnet_id). |
ovh/gateway/providers.tf |
Declares required Terraform and provider versions for ovh and time to support the gateway resource and timestamping. |
ovh/gateway/outputs.tf |
Exposes the ovh_cloud_project_gateway.gateway.id so callers can reference the created gateway. |
ovh/gateway/main.tf |
Sets up shared local interpolated_tags and a time_static.last_update resource, mirroring tagging patterns in other OVH modules. |
ovh/gateway/gateway.tf |
Creates the ovh_cloud_project_gateway resource wired to the module inputs (project ID, model, region, network, subnet). |
ovh/gateway/README.md |
Adds user-facing documentation for the new gateway module (requirements, providers, inputs/outputs), currently with naming and markdown table formatting issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fredleger
approved these changes
Mar 17, 2026
Contributor
|
@Libr4rian @ffederighi I merged it considering the "WIP" was a relicate of previous work. Was i right ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.