Skip to content

Commit d77077a

Browse files
author
pfwd
committed
Fixing tests and replacing default props
1 parent 23b8f1a commit d77077a

2 files changed

Lines changed: 17 additions & 18 deletions

File tree

src/HeaderMenu.js

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,29 @@
11
import React from 'react';
22

3-
function HeaderMenu(props) {
3+
const defaultMenu = {
4+
items: [
5+
{
6+
name: "Menu Item 1",
7+
url: "/menu-item-1"
8+
},
9+
{
10+
name: "Menu Item 2",
11+
url: "/menu-item-2"
12+
}
13+
]
14+
}
15+
16+
17+
function HeaderMenu({menu = defaultMenu}) {
418
return (
519
<nav>
620
<ul>
7-
{props.menu.items.map((item, key) =>
21+
{ menu.items.map((item, key) =>
822
<li key={`li-` + key}><a key={key} href={item.url}>{item.name}</a></li>
923
)}
1024
</ul>
1125
</nav>
1226
)
1327
}
1428

15-
HeaderMenu.defaultProps = {
16-
menu: {
17-
items: [
18-
{
19-
name: "Menu Item 1",
20-
url: "/menu-item-1"
21-
},
22-
{
23-
name: "Menu Item 2",
24-
url: "/menu-item-2"
25-
}
26-
]
27-
}
28-
}
29-
3029
export default HeaderMenu;

src/HeaderMenu.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import {render, screen} from '@testing-library/react';
3-
import '@testing-library/jest-dom/extend-expect';
3+
import '@testing-library/jest-dom';
44
import HeaderMenu from "./HeaderMenu";
55

66

0 commit comments

Comments
 (0)