Auto-include msgpack in VenvTask, remove explicit declarations from examples

howtis · howtis · commit cb22c016f58b · 2026-06-23T18:22:39.000+09:00
VenvTask.createVenv() now automatically adds msgpack to the packages list since bridge.py always requires it. Removed explicit msgpack declarations from all 13 example projects.
diff --git a/python-embed-examples/basic-eval/build.gradle b/python-embed-examples/basic-eval/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/batch-operations/build.gradle b/python-embed-examples/batch-operations/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/callback-bridge/build.gradle b/python-embed-examples/callback-bridge/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/configuration/build.gradle b/python-embed-examples/configuration/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/error-handling/build.gradle b/python-embed-examples/error-handling/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/health-monitor/build.gradle b/python-embed-examples/health-monitor/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/numpy-basic/build.gradle b/python-embed-examples/numpy-basic/build.gradle
@@ -12,5 +12,5 @@ dependencies {
 }
 
 pythonEmbed {
-    packages = ['numpy', 'msgpack']
+    packages = ['numpy']
 }
diff --git a/python-embed-examples/object-handle/build.gradle b/python-embed-examples/object-handle/build.gradle
@@ -12,5 +12,5 @@ dependencies {
 }
 
 pythonEmbed {
-    packages = ['msgpack','numpy']
+    packages = ['numpy']
 }
diff --git a/python-embed-examples/pandas-dataframe/build.gradle b/python-embed-examples/pandas-dataframe/build.gradle
@@ -12,5 +12,5 @@ dependencies {
 }
 
 pythonEmbed {
-    packages = ['pandas', 'msgpack']
+    packages = ['pandas']
 }
diff --git a/python-embed-examples/pool-async/build.gradle b/python-embed-examples/pool-async/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/proxy-object/build.gradle b/python-embed-examples/proxy-object/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-examples/spring-boot-example/build.gradle b/python-embed-examples/spring-boot-example/build.gradle
@@ -15,6 +15,6 @@ dependencies {
     implementation 'org.springframework.boot:spring-boot-starter-actuator'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
+tasks.register('prepareKotlinBuildScriptModel') {
 }
+
diff --git a/python-embed-examples/streaming/build.gradle b/python-embed-examples/streaming/build.gradle
@@ -11,6 +11,3 @@ dependencies {
     implementation 'org.slf4j:slf4j-simple:2.0.16'
 }
 
-pythonEmbed {
-    packages = ['msgpack']
-}
diff --git a/python-embed-gradle-plugin/src/main/java/io/github/howtis/pythonembed/gradle/VenvTask.java b/python-embed-gradle-plugin/src/main/java/io/github/howtis/pythonembed/gradle/VenvTask.java
@@ -93,6 +93,10 @@ private static class Fingerprint {
     @TaskAction
     public void createVenv() {
         List<String> packages = new ArrayList<>(getPackages().get());
+        // msgpack is always required by bridge.py, auto-include
+        if (!packages.contains("msgpack")) {
+            packages.add("msgpack");
+        }
         String requirementsFile = getRequirementsFile().getOrNull();
         String pyprojectTomlFile = getPyprojectTomlFile().getOrNull();
 
diff --git a/python-embed-gradle-plugin/src/test/java/io/github/howtis/pythonembed/gradle/VenvTaskTest.java b/python-embed-gradle-plugin/src/test/java/io/github/howtis/pythonembed/gradle/VenvTaskTest.java
@@ -152,9 +152,10 @@ void createVenv_fingerprintMatchSkipsSetup(@TempDir Path tempDir) throws IOExcep
         Files.createFile(scriptsDir.resolve("python.exe"));
 
         // Set packages and compute expected fingerprint
+        // msgpack is auto-added by VenvTask, so include it in the expected hash
         List<String> packages = List.of("numpy==1.26.4");
         task.getPackages().set(packages);
-        String expectedHash = task.computePackageHash(packages, null, List.of(), null);
+        String expectedHash = task.computePackageHash(List.of("numpy==1.26.4", "msgpack"), null, List.of(), null);
 
         // Write matching fingerprint file
         Properties fp = new Properties();

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,3 @@ dependencies {`
`11`	`11`	`implementation 'org.slf4j:slf4j-simple:2.0.16'`
`12`	`12`	`}`
`13`	`13`
`14`		`-pythonEmbed {`
`15`		`- packages = ['msgpack']`
`16`		`-}`
Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,5 @@ dependencies {`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`pythonEmbed {`
`15`		`- packages = ['numpy', 'msgpack']`
	`15`	`+ packages = ['numpy']`
`16`	`16`	`}`