Implement onStateChange in TracingStateListener jni interface (react#54824)

Summary:

# Changelog: [Internal]

The previous approach was causing a crash if we would attempt to register multiple listeners on Android side, because we would static-initialize different methods from different instances.

When the native code tried to invoke onStateChanged on a different listener class, JNI threw an error.

Instead, we will cache the interface method.

Reviewed By: javache

Differential Revision: D88734482

Author: hoxyq

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.cpp

@@ -17,35 +17,6 @@ using namespace facebook::react::jsinspector_modern;
 
 namespace facebook::react {
 
-namespace {
-jni::local_ref<JTracingState::javaobject> convertCPPTracingStateToJava(
-    TracingState tracingState) {
-  auto tracingStateClass = jni::findClassLocal(
-      "com/facebook/react/devsupport/inspector/TracingState");
-  auto valueOfMethod =
-      tracingStateClass->getStaticMethod<JTracingState(jstring)>("valueOf");
-
-  switch (tracingState) {
-    case TracingState::Disabled:
-      return valueOfMethod(
-          tracingStateClass, jni::make_jstring("DISABLED").get());
-
-    case TracingState::EnabledInBackgroundMode:
-      return valueOfMethod(
-          tracingStateClass,
-          jni::make_jstring("ENABLED_IN_BACKGROUND_MODE").get());
-
-    case TracingState::EnabledInCDPMode:
-      return valueOfMethod(
-          tracingStateClass, jni::make_jstring("ENABLED_IN_CDP_MODE").get());
-
-    default:
-      jni::throwNewJavaException(
-          "java/lang/IllegalStateException", "Unexpected new TracingState.");
-  }
-}
-} // namespace
-
 JReactHostInspectorTarget::JReactHostInspectorTarget(
     alias_ref<JReactHostInspectorTarget::javaobject> jobj,
     alias_ref<JReactHostImpl> reactHostImpl,
@@ -266,17 +237,8 @@ JReactHostInspectorTarget::getTracingState() {
 jlong JReactHostInspectorTarget::registerTracingStateListener(
     jni::alias_ref<JTracingStateListener::javaobject> listener) {
   auto cppListener = [globalRef = make_global(listener)](
-                         TracingState state, bool screenshotsEnabled) {
-    static auto method =
-        globalRef->getClass()
-            ->getMethod<void(
-                jni::local_ref<JTracingState::javaobject>, jboolean)>(
-                "onStateChanged");
-
-    method(
-        globalRef,
-        convertCPPTracingStateToJava(state),
-        static_cast<jboolean>(screenshotsEnabled));
+                         TracingState tracingState, bool screenshotsEnabled) {
+    globalRef->onStateChanged(tracingState, screenshotsEnabled);
   };
 
   return static_cast<jlong>(

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/JReactHostInspectorTarget.h

@@ -20,16 +20,53 @@
 
 namespace facebook::react {
 
-struct JTaskInterface : public jni::JavaClass<JTaskInterface> {
-  static constexpr auto kJavaDescriptor = "Lcom/facebook/react/interfaces/TaskInterface;";
-};
-
 struct JTracingState : public jni::JavaClass<JTracingState> {
   static constexpr auto kJavaDescriptor = "Lcom/facebook/react/devsupport/inspector/TracingState;";
 };
 
+namespace {
+
+enum class TracingState {
+  Disabled,
+  EnabledInBackgroundMode,
+  EnabledInCDPMode,
+};
+
+jni::local_ref<JTracingState::javaobject> convertCPPTracingStateToJava(TracingState tracingState)
+{
+  auto tracingStateClass = jni::findClassLocal("com/facebook/react/devsupport/inspector/TracingState");
+  auto valueOfMethod = tracingStateClass->getStaticMethod<JTracingState(jstring)>("valueOf");
+
+  switch (tracingState) {
+    case TracingState::Disabled:
+      return valueOfMethod(tracingStateClass, jni::make_jstring("DISABLED").get());
+
+    case TracingState::EnabledInBackgroundMode:
+      return valueOfMethod(tracingStateClass, jni::make_jstring("ENABLED_IN_BACKGROUND_MODE").get());
+
+    case TracingState::EnabledInCDPMode:
+      return valueOfMethod(tracingStateClass, jni::make_jstring("ENABLED_IN_CDP_MODE").get());
+
+    default:
+      jni::throwNewJavaException("java/lang/IllegalStateException", "Unexpected new TracingState.");
+  }
+}
+
+} // namespace
+
+struct JTaskInterface : public jni::JavaClass<JTaskInterface> {
+  static constexpr auto kJavaDescriptor = "Lcom/facebook/react/interfaces/TaskInterface;";
+};
+
 struct JTracingStateListener : public jni::JavaClass<JTracingStateListener> {
   static constexpr auto kJavaDescriptor = "Lcom/facebook/react/devsupport/inspector/TracingStateListener;";
+
+  void onStateChanged(TracingState tracingState, bool screenshotsEnabled) const
+  {
+    static auto method =
+        javaClassStatic()->getMethod<void(jni::local_ref<JTracingState::javaobject>, jboolean)>("onStateChanged");
+    return method(self(), convertCPPTracingStateToJava(tracingState), static_cast<jboolean>(screenshotsEnabled));
+  }
 };
 
 struct JFrameTimingSequence : public jni::JavaClass<JFrameTimingSequence> {
@@ -112,12 +149,6 @@ struct JReactHostImpl : public jni::JavaClass<JReactHostImpl> {
   }
 };
 
-enum class TracingState {
-  Disabled,
-  EnabledInBackgroundMode,
-  EnabledInCDPMode,
-};
-
 /**
  * A callback that will be invoked when tracing state has changed.
  */