EH: CS-1333 add reporting of online usage to reporting file#80
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds configurable online usage reporting to the JSONL reporting pipeline, allowing selected scaled usage variables from running job reports to be emitted as online_usage records.
Changes:
- Adds parsing and validation for
reporting_params=online_usage=.... - Adds JSONL online usage record emission from qmaster job reports.
- Documents the new
online_usagereporting parameter and record schema.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
source/libs/sgeobj/sge_conf.h |
Declares online usage configuration accessors and parser. |
source/libs/sgeobj/sge_conf.cc |
Parses, validates, stores, and exposes online usage variables. |
source/libs/sgeobj/msg_sgeobjlib.h |
Adds validation error text for empty online usage tokens. |
source/daemons/qmaster/ocs_ReportingFileWriter.h |
Adds online usage dispatcher API and shared configuration storage. |
source/daemons/qmaster/ocs_ReportingFileWriter.cc |
Propagates configured variables and dispatches online usage records. |
source/daemons/qmaster/ocs_JsonReportingFileWriter.h |
Adds JSON writer override for online usage records. |
source/daemons/qmaster/ocs_JsonReportingFileWriter.cc |
Implements JSONL online_usage record creation. |
source/daemons/qmaster/job_report_qmaster.cc |
Hooks online usage emission into running job report processing. |
source/daemons/qmaster/configuration_qmaster.cc |
Adds pre-commit validation for online_usage config values. |
doc/markdown/man/man5/sge_reporting.md |
Documents the online_usage record schema. |
doc/markdown/man/man5/sge_conf.md |
Documents the new online_usage reporting parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/hpc-gridware/clusterscheduler/sessions/97b08c8e-6ef6-4904-83ef-54a42e452553 Co-authored-by: jgabler-hpc <153002638+jgabler-hpc@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
jgabler-hpc
added a commit
that referenced
this pull request
May 16, 2026
* TA: CS-2203 Add online_usage parsing to reporting_params * TA: CS-2199 Add create_online_usage_record writer plumbing + JSONL implementation * TA: CS-2200 Hook online_usage emission into the qmaster job-report path * TA: CS-2202 Document online_usage in sge_conf.5 and sge_reporting.5 * corrected description of valid variable names for online_usag * do not create online_usage records with an empty usage list * improved validation of online_usage, I18N * Potential fix for pull request finding * fix: clear online_usage defaults when reloading reporting_params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.