Skip to content

EH: CS-1333 add reporting of online usage to reporting file#80

Merged
jgabler-hpc merged 9 commits into
V91_BRANCHfrom
JG_CS-1333_BRANCH
May 16, 2026
Merged

EH: CS-1333 add reporting of online usage to reporting file#80
jgabler-hpc merged 9 commits into
V91_BRANCHfrom
JG_CS-1333_BRANCH

Conversation

@jgabler-hpc
Copy link
Copy Markdown
Contributor

No description provided.

@jgabler-hpc jgabler-hpc self-assigned this May 16, 2026
Copilot AI review requested due to automatic review settings May 16, 2026 10:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds configurable online usage reporting to the JSONL reporting pipeline, allowing selected scaled usage variables from running job reports to be emitted as online_usage records.

Changes:

  • Adds parsing and validation for reporting_params=online_usage=....
  • Adds JSONL online usage record emission from qmaster job reports.
  • Documents the new online_usage reporting parameter and record schema.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
source/libs/sgeobj/sge_conf.h Declares online usage configuration accessors and parser.
source/libs/sgeobj/sge_conf.cc Parses, validates, stores, and exposes online usage variables.
source/libs/sgeobj/msg_sgeobjlib.h Adds validation error text for empty online usage tokens.
source/daemons/qmaster/ocs_ReportingFileWriter.h Adds online usage dispatcher API and shared configuration storage.
source/daemons/qmaster/ocs_ReportingFileWriter.cc Propagates configured variables and dispatches online usage records.
source/daemons/qmaster/ocs_JsonReportingFileWriter.h Adds JSON writer override for online usage records.
source/daemons/qmaster/ocs_JsonReportingFileWriter.cc Implements JSONL online_usage record creation.
source/daemons/qmaster/job_report_qmaster.cc Hooks online usage emission into running job report processing.
source/daemons/qmaster/configuration_qmaster.cc Adds pre-commit validation for online_usage config values.
doc/markdown/man/man5/sge_reporting.md Documents the online_usage record schema.
doc/markdown/man/man5/sge_conf.md Documents the new online_usage reporting parameter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/libs/sgeobj/sge_conf.cc
Comment thread source/daemons/qmaster/job_report_qmaster.cc Outdated
jgabler-hpc and others added 2 commits May 16, 2026 12:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented May 16, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.open-mpi.org
    • Triggering command: /usr/local/bin/cmake /usr/local/bin/cmake -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P /home/REDACTED/work/clusterscheduler/clusterscheduler/3rd_party/hwloc/src/3rd_party_hwloc-stamp/download-3rd_party_hwloc.cmake (dns block)
    • Triggering command: /usr/local/bin/cmake /usr/local/bin/cmake -DCMAKE_MESSAGE_LOG_LEVEL=VERBOSE -P /home/REDACTED/work/clusterscheduler/clusterscheduler/3rd_party/hwloc/src/3rd_party_hwloc-stamp/download-3rd_party_hwloc.cmake -plu�� /usr/local/bin/cmake -E echo_append -plugin-opt=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper as -plugin-opt=-pas/usr/bin/ld -plugin-opt=-pas--help p.o cc -c eduler/3rd_party/berkeleydb/src/-nxv -Idist/../src as -D_REENTRANT -O3 .o as (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@jgabler-hpc jgabler-hpc merged commit ae018b7 into V91_BRANCH May 16, 2026
jgabler-hpc added a commit that referenced this pull request May 16, 2026
* TA: CS-2203 Add online_usage parsing to reporting_params
* TA: CS-2199 Add create_online_usage_record writer plumbing + JSONL implementation
* TA: CS-2200 Hook online_usage emission into the qmaster job-report path
* TA: CS-2202 Document online_usage in sge_conf.5 and sge_reporting.5
* corrected description of valid variable names for online_usag
* do not create online_usage records with an empty usage list
* improved validation of online_usage, I18N
* Potential fix for pull request finding
* fix: clear online_usage defaults when reloading reporting_params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants