common: build fixes for FreeBSD (stat64/lstat64, headers, logging)

These are the core FreeBSD portability changes extracted from the FreeBSD ports tree work. The port currently is still under review.
Port PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291679
Port review: https://reviews.freebsd.org/D54230

The Patches:
 - Add FreeBSD compatibility for stat64/lstat64 by mapping them to stat/lstat (which are 64 bit by default on FreeBSD)
 - Include missing system headers in the path/parameter helper so struct stat and related macros are consistently available
 - Fix MFU_LOG(... "errno=%d %s" ...) callsites in mfu_util.c to actually pass both errno and strerrno(errno) (prevents format/argument mismatch and undefined behavior)
 - Include <fcntl.h> in mfu_util.c for file/flag-related definitions used by the code on non-Linux systems

Signed-off-by: Rikka Göring <rikka.goering@outlook.de>

Author: GenericRikka

src/common/mfu_bz2.c

@@ -5,13 +5,14 @@
 #include <string.h>
 #include <errno.h>
 
-/* for statfs */
-#include <sys/vfs.h>
+#if defined(__linux__)
+#include <sys/vfs.h>  /* for statfs */
+#endif
 
+#if defined(__linux__) && LUSTRE_SUPPORT
 /* for LL_SUPER_MAGIC */
-#if LUSTRE_SUPPORT
 #include <lustre/lustre_user.h>
-#endif /* LUSTRE_SUPPORT */
+#endif /* __linux__ && LUSTRE_SUPPORT */
 
 #include "mpi.h"
 #include "mfu.h"

src/common/mfu_bz2.h

@@ -1,6 +1,7 @@
 #ifndef MFU_BZ2_H
 #define MFU_BZ2_H
 
+int mfu_compress_bz2_static(const char* src_name, const char* dst_name, int b_size);
 int mfu_compress_bz2(const char* src_name, const char* dst_name, int b_size);
 int mfu_decompress_bz2(const char* src_name, const char* dst_name);
 

src/common/mfu_bz2_static.c

@@ -5,7 +5,9 @@
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
+#if defined(__linux__)
 #include <sys/sysinfo.h>
+#endif
 #include <string.h>
 #include <sys/time.h>
 #include <sys/resource.h>
@@ -23,6 +25,10 @@
 #include "mfu.h"
 #include "mfu_bz2.h"
 
+#ifndef O_LARGEFILE
+#define O_LARGEFILE 0
+#endif
+
 #define FILE_MODE (S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH)
 
 int mfu_compress_bz2_static(const char* src_name, const char* dst_name, int b_size)

src/common/mfu_compress_bz2_libcircle.c

@@ -5,7 +5,9 @@
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
+#if defined(__linux__)
 #include <sys/sysinfo.h>
+#endif
 #include <string.h>
 #include <sys/time.h>
 #include <sys/resource.h>
@@ -23,6 +25,7 @@
 #include "mfu.h"
 #include "mfu_bz2.h"
 
+#if defined(__linux__)
 #define FILE_MODE (S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH)
 
 struct block_info {
@@ -531,3 +534,11 @@ int mfu_compress_bz2_libcircle(const char* src, const char* dst, int b_size, ssi
 
     return rc;
 }
+#else
+int mfu_compress_bz2_libcircle(const char* src, const char* dst,
+                                int b_size, ssize_t opts_memory)
+{
+    (void)opts_memory;
+    return mfu_compress_bz2_static(src, dst, b_size);
+}
+#endif

src/common/mfu_decompress_bz2_libcircle.c

@@ -5,7 +5,9 @@
 #include <unistd.h>
 #include <stdio.h>
 #include <stdlib.h>
+#if defined(__linux__)
 #include <sys/sysinfo.h>
+#endif
 #include <string.h>
 #include <sys/time.h>
 #include <sys/resource.h>

src/common/mfu_flist.c

@@ -12,6 +12,9 @@
 #include <stdlib.h>
 #include <sys/types.h>
 #include <sys/stat.h>
+#if !defined(__linux__)
+#undef DCOPY_USE_XATTRS
+#endif
 #include <string.h>
 #include <unistd.h>
 #include <getopt.h>
@@ -35,8 +38,10 @@
 #include <sys/ioctl.h>
 #include <sys/param.h>
 
+#ifdef __linux__
 #include <linux/fs.h>
 #include <linux/fiemap.h>
+#endif
 
 #include <libgen.h> /* dirname */
 #include "libcircle.h"

src/common/mfu_flist.h

@@ -44,7 +44,7 @@ extern "C" {
 #include <stdbool.h>
 #include "mpi.h"
 
-#if DCOPY_USE_XATTRS
+#if defined(__linux__) && DCOPY_USE_XATTRS
 #include <sys/xattr.h>
 /*
  * Newer versions of attr deprecated attr/xattr.h which defines ENOATTR as a

src/common/mfu_flist_archive.c

@@ -40,6 +40,14 @@
 #include <lustre/lustreapi.h>
 #endif
 
+#ifndef O_NOATIME
+#define O_NOATIME 0
+#endif
+
+#ifndef O_LARGEFILE
+#define O_LARGEFILE 0
+#endif
+
 /* for magic value we use "DTAR_IDX" in ASCII (8-bit) */
 #define DTAR_MAGIC (0x445441525F494458)
 
@@ -5265,7 +5273,12 @@ static int extract_xattrs(
                 r = archive_entry_xattr_next(entry, &xname, &xval, &xsize);
                 if (r == ARCHIVE_OK) {
                     /* successfully extracted xattr, now try to set it */
+#ifdef __linux__
                     int set_rc = setxattr(path, xname, xval, xsize, 0);
+#else
+                    int set_rc = -1;
+                    errno = ENOTSUP;
+#endif
                     if (set_rc == -1) {
                         MFU_LOG(MFU_LOG_ERR, "failed to setxattr '%s' on '%s' errno=%d %s",
                             xname, path, errno, strerror(errno) 

src/common/mfu_flist_copy.c

@@ -39,8 +39,15 @@
 #include <sys/ioctl.h>
 #include <sys/param.h>
 
+#ifdef __linux__
 #include <linux/fs.h>
 #include <linux/fiemap.h>
+typedef __u64 mfu_u64;
+typedef __u32 mfu_u32;
+#else
+typedef uint64_t mfu_u64;
+typedef uint32_t mfu_u32;
+#endif
 
 /* define PRI64 */
 #include <inttypes.h>
@@ -72,6 +79,10 @@
 #include <linux/hpssfs.h>
 #endif
 
+#ifndef O_NOATIME
+#define O_NOATIME 0
+#endif
+
 /****************************************
  * Define types
  ***************************************/
@@ -99,6 +110,47 @@ typedef struct {
 #endif
 } mfu_copy_file_cache_t;
 
+#if DCOPY_USE_XATTRS && !defined(__linux__)
+
+#include <errno.h>
+#include <sys/types.h>
+
+static inline ssize_t
+llistxattr(const char *path, char *list, size_t size)
+{
+    (void)path;
+    (void)list;
+    (void)size;
+    errno = ENOTSUP;
+    return -1;
+}
+
+static inline ssize_t
+lgetxattr(const char *path, const char *name, void *value, size_t size)
+{
+    (void)path;
+    (void)name;
+    (void)value;
+    (void)size;
+    errno = ENOTSUP;
+    return -1;
+}
+
+static inline int
+lsetxattr(const char *path, const char *name,
+          const void *value, size_t size, int flags)
+{
+    (void)path;
+    (void)name;
+    (void)value;
+    (void)size;
+    (void)flags;
+    errno = ENOTSUP;
+    return -1;
+}
+
+#endif
+
 /****************************************
  * Define globals
  ***************************************/
@@ -1889,13 +1941,13 @@ static int mfu_copy_file_normal(
 }
 
 struct mfu_extent {
-    __u64 me_logical;  /* logical offset in bytes for the start of the extent */
-    __u64 me_length;   /* length in bytes for this extent */
+    mfu_u64 me_logical;  /* logical offset in bytes for the start of the extent */
+    mfu_u64 me_length;   /* length in bytes for this extent */
 };
 
 struct mfu_extent_list {
-    __u32 mel_mapped_extents;/* number of extents that were mapped */
-    __u32 mel_extent_count;  /* size of fm_extents array */
+    mfu_u32 mel_mapped_extents;/* number of extents that were mapped */
+    mfu_u32 mel_extent_count;  /* size of fm_extents array */
     struct mfu_extent mel_extents[0]; /* array of mapped extents */
 };
 
@@ -1926,6 +1978,7 @@ struct mfu_extent_list *mfu_extent_list_realloc(struct mfu_extent_list *orig, si
     return extent_list;
 }
 
+#ifdef __linux__
 static struct mfu_extent_list * mfu_fiemap_get_extents(
     const char* src,
     const char* dest,
@@ -2026,6 +2079,7 @@ static struct mfu_extent_list * mfu_fiemap_get_extents(
 fail_no_fiemap:
     return NULL;
 }
+#endif
 
 /*
  * if returned extent_list * is non-NULL, and normal_copy_required == false,
@@ -2175,6 +2229,7 @@ static int mfu_copy_file_extents(
             free(extent_list);
         }
 
+#ifdef __linux__
         /* extents acquired by fiemap ioctl */
         extent_list = mfu_fiemap_get_extents( src, dest,
             offset, length, file_size, normal_copy_required, copy_opts,
@@ -2183,6 +2238,9 @@ static int mfu_copy_file_extents(
         if (!extent_list || *normal_copy_required == true) {
             goto fail_fiemap;
         }
+#else
+        goto fail_normal_copy;
+#endif
     }
 
     /* seek to offset in source file */

src/common/mfu_flist_walk.c

@@ -39,6 +39,10 @@
 #include "mfu_flist_internal.h"
 #include "strmap.h"
 
+#ifndef O_NOATIME
+#define O_NOATIME 0
+#endif
+
 /****************************************
  * Globals
  ***************************************/
@@ -205,7 +209,13 @@ static void walk_getdents_process_dir(const char* dir, CIRCLE_handle* handle)
     /* Read all directory entries */
     while (1) {
         /* execute system call to get block of directory entries */
-        int nread = syscall(SYS_getdents, mfu_file->fd, buf, (int) BUF_SIZE);
+        int nread;
+
+#ifdef __linux__
+        nread = syscall(SYS_getdents, mfu_file->fd, buf, (int)BUF_SIZE);
+#else
+        nread = getdents(mfu_file->fd, buf, (size_t)BUF_SIZE);
+#endif
         if (nread == -1) {
             MFU_LOG(MFU_LOG_ERR, "syscall to getdents failed when reading `%s' (errno=%d %s)", dir, errno, strerror(errno));
             WALK_RESULT = -1;
@@ -767,7 +777,7 @@ void mfu_flist_stat(
         /* check whether we should skip this item */
         if (skip_fn != NULL && skip_fn(name, skip_args)) {
             /* skip this file, don't include it in new list */
-            MFU_LOG(MFU_LOG_INFO, "skip %s");
+            MFU_LOG(MFU_LOG_INFO, "skip %s", name);
             continue;
         }