Skip to content

Ensure error code is kept if destination dir is not writable #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ColemanTom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure error code is kept if destination dir is not writable #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dsync/dsync.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3361,6 +3361,7 @@ int main(int argc, char **argv)
dest_parent_str, errno, strerror(errno));
if (!options.dry_run) {
mfu_free(&dest_parent_str);
rc = errno;
goto ERROR;
Comment on lines +3364 to 3365

@daltonbohning daltonbohning Mar 25, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rc=errno seems reasonable, but it seems the goto maybe should actually be goto dsync_common_cleanup since some things like mfu_copy_opts_delete(&copy_opts); need to be done. Though I'm not sure if everything in that cleanup section is needed

@ColemanTom ColemanTom Mar 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably correct. I'm happy to change that if you want.

}
}
Expand Down