HPCC-36035 Adjust loops per review recommendation

asselitx · asselitx · commit f81811399417 · 2026-03-25T15:32:05.000-05:00
Use dedicated for loop indices to avoid overflow/underflow or misuse after
loop ends.

Signed-off-by: Terrence Asselin &lt;terrence.asselin+copilot@lexisnexisrisk.com&gt;
diff --git a/esp/bindings/SOAP/xpp/fxpp/FragmentedXmlPullParser.cpp b/esp/bindings/SOAP/xpp/fxpp/FragmentedXmlPullParser.cpp
@@ -216,14 +216,11 @@ class CFragmentedXmlPullParser : public IFragmentedXmlPullParser
                     }
                     else
                     {
-                        while (true)
+                        for (uint8_t i=0; i<=laIndex; ++i)
                         {
-                            la = peekDataFrame(laIndex);
+                            la = peekDataFrame(i);
                             if (la)
                                 la->state = DataFrame::FrameIgnored;
-                            if (laIndex == 0)
-                                break;
-                            --laIndex;
                         }
                         pushFragment(injector.m_frame.getLink());
                     }
diff --git a/esp/services/ws_machine/ws_machineService.cpp b/esp/services/ws_machine/ws_machineService.cpp
@@ -499,7 +499,7 @@ void Cws_machineEx::setProcessRequest(CGetMachineInfoData& machineInfoData, Bool
             processTypeStr = processType;
     }
 
-    for (; numIps > 0; --numIps)
+    for (unsigned i=0; i<numIps; ++i)
     {
         unsigned numAddr;
         if (ipAddr.getNetAddress(sizeof(numAddr),&numAddr)!=sizeof(numAddr))

Original file line number	Diff line number	Diff line change
`@@ -216,14 +216,11 @@ class CFragmentedXmlPullParser : public IFragmentedXmlPullParser`
`216`	`216`	`}`
`217`	`217`	`else`
`218`	`218`	`{`
`219`		`- while (true)`
	`219`	`+ for (uint8_t i=0; i<=laIndex; ++i)`
`220`	`220`	`{`
`221`		`- la = peekDataFrame(laIndex);`
	`221`	`+ la = peekDataFrame(i);`
`222`	`222`	`if (la)`
`223`	`223`	`la->state = DataFrame::FrameIgnored;`
`224`		`- if (laIndex == 0)`
`225`		`- break;`
`226`		`- --laIndex;`
`227`	`224`	`}`
`228`	`225`	`pushFragment(injector.m_frame.getLink());`
`229`	`226`	`}`
Original file line number	Diff line number	Diff line change
`@@ -499,7 +499,7 @@ void Cws_machineEx::setProcessRequest(CGetMachineInfoData& machineInfoData, Bool`
`499`	`499`	`processTypeStr = processType;`
`500`	`500`	`}`
`501`	`501`
`502`		`- for (; numIps > 0; --numIps)`
	`502`	`+ for (unsigned i=0; i<numIps; ++i)`
`503`	`503`	`{`
`504`	`504`	`unsigned numAddr;`
`505`	`505`	`if (ipAddr.getNetAddress(sizeof(numAddr),&numAddr)!=sizeof(numAddr))`