Skip to content

HPCC-34790 ECL Watch v9 contents in file view not updated when file is rewritten#20311

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-9.8.xfrom
jeclrsg:hpcc-34790-file-contents-bypass-cache
Sep 4, 2025
Merged

HPCC-34790 ECL Watch v9 contents in file view not updated when file is rewritten#20311
GordonSmith merged 1 commit into
hpcc-systems:candidate-9.8.xfrom
jeclrsg:hpcc-34790-file-contents-bypass-cache

Conversation

@jeclrsg
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg commented Aug 19, 2025

fixes an issue in ECL Watch v9, when viewing the contents of a logical file, the user cannot see the most up-to-date data as they can when using the v5 UI

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copilot AI review requested due to automatic review settings August 19, 2025 17:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue in ECL Watch v9 where the file contents view was not showing the most up-to-date data when a logical file was rewritten, bringing it in line with the v5 UI behavior.

  • Modifies the refresh functionality to bypass cache when updating file contents
  • Ensures users see current data rather than cached/stale content

Comment thread esp/src/src-react/components/Result.tsx Outdated
@jeclrsg
Copy link
Copy Markdown
Contributor Author

jeclrsg commented Aug 19, 2025

@jeclrsg will need to bump hpcc-js/eclwatch and hpcc-js/comms in package.json. depends upon hpcc-systems/Visualization#4437

@jeclrsg jeclrsg force-pushed the hpcc-34790-file-contents-bypass-cache branch from b873a23 to 588e7b1 Compare August 19, 2025 17:22
@jeclrsg jeclrsg requested a review from GordonSmith August 19, 2025 17:23
@github-actions
Copy link
Copy Markdown

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-34790

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

Copy link
Copy Markdown
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes in the viz framework should be released now.

…s rewritten

fixes an issue in ECL Watch v9, when viewing the contents of a logical
file, the user cannot see the most up-to-date data as they can when
using the v5 UI

Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
@jeclrsg jeclrsg force-pushed the hpcc-34790-file-contents-bypass-cache branch from 588e7b1 to d2d6d94 Compare September 2, 2025 14:11
@jeclrsg jeclrsg requested a review from GordonSmith September 2, 2025 14:52
@GordonSmith GordonSmith merged commit a451086 into hpcc-systems:candidate-9.8.x Sep 4, 2025
46 of 48 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

Jirabot Action Result:
Added fix version: 9.8.116
Added fix version: 9.10.62
Added fix version: 9.12.36
Added fix version: 9.14.18
Workflow Transition: 'Resolve issue'

@jeclrsg jeclrsg deleted the hpcc-34790-file-contents-bypass-cache branch October 13, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants