Skip to content

HPCC-25201 Add React Activities#20356

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-9.8.xfrom
GordonSmith:HPCC-25201-REACT_ACTIVITIES
Sep 18, 2025
Merged

HPCC-25201 Add React Activities#20356
GordonSmith merged 1 commit into
hpcc-systems:candidate-9.8.xfrom
GordonSmith:HPCC-25201-REACT_ACTIVITIES

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Sep 10, 2025

Signed-off-by Gordon Smith GordonJSmith@gmail.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copilot AI review requested due to automatic review settings September 10, 2025 09:51
@github-actions
Copy link
Copy Markdown

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-25201

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #20356

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds React-based Activities component cards as a preview feature to the ECL Watch web interface. It introduces new card-based visualizations for activities, disk usage, and queue management alongside the existing activities view.

  • Adds new /activities-preview route with React card-based UI components
  • Implements reusable card components for queues, disk usage, and activities
  • Extracts shared utility functions from ESPDFUWorkunit for better code reuse

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
esp/src/tests/v9-activities-preview.spec.ts Adds Playwright tests for the new activities preview page
esp/src/tests/test-wus.json Removes test workunit configuration file
esp/src/src/ESPDFUWorkunit.ts Extracts state and protection image utility functions for reuse
esp/src/src/DiskUsage.ts Adds ClusterGauge class for disk usage visualization
esp/src/src-react/util/metricGraph.ts Updates CSS import path for React styling
esp/src/src-react/routes.tsx Adds new activities-preview route
esp/src/src-react/hooks/queue.ts Implements queue management hooks and types
esp/src/src-react/hooks/index.ts Exports new queue hooks
esp/src/src-react/hooks/diskUsage.ts Adds disk usage data hooks
esp/src/src-react/hooks/banner.tsx Updates activity hook usage pattern
esp/src/src-react/hooks/activity.ts Refactors activity hook return value and improves type safety
esp/src/src-react/components/controls/OverflowMenu.tsx Enhances menu button styling
esp/src/src-react/components/controls/FlatTreeEx.tsx Updates React.FC to React.FunctionComponent
esp/src/src-react/components/cards/QueueCard.tsx Implements queue management card component
esp/src/src-react/components/cards/GenericCard.tsx Creates reusable card component foundation
esp/src/src-react/components/cards/DiskUsageCard.tsx Implements disk usage visualization cards
esp/src/src-react/components/cards/CardGroup.tsx Creates grid layout component for cards
esp/src/src-react/components/Menu.tsx Adds activities preview menu item
esp/src/src-react/components/DiskUsage.tsx Refactors disk usage component to use cards
esp/src/src-react/components/ActivitiesCards.tsx Implements main activities preview page
esp/src/src-dojo/nls/hpcc.ts Adds new localization strings
esp/src/.gitignore Adds test-wus.json to gitignore
esp/src/.github/instructions/react-coding.instructions.md Updates React component type preference

Comment thread esp/src/src-react/hooks/queue.ts Outdated
Comment thread esp/src/src-react/components/cards/QueueCard.tsx Outdated
Comment thread esp/src/src-react/components/cards/GenericCard.tsx
@GordonSmith
Copy link
Copy Markdown
Member Author

@jeclrsg this is the same PR as previously, except its a tech preview rather than marking the other as legacy.

Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith looked good. All my comments were just nitpicks. Copilot still had a comment that was unaddressed. Don't remember which file, but it was just suggesting includes() over indexOf() somewhere

Comment thread esp/src/.github/instructions/react-coding.instructions.md
Comment on lines +66 to +71
pushClusters(activity?.HThorClusterList?.TargetCluster, 1);
pushClusters(activity?.RoxieClusterList?.TargetCluster, 2);
pushClusters(activity?.ThorClusterList?.TargetCluster, 3);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an enum for these ints? or is there such a thing already somewhere in comms maybe?

Comment thread esp/src/src-react/hooks/queue.ts
Comment thread esp/src/src-react/hooks/queue.ts
Comment thread esp/src/src-react/hooks/queue.ts Outdated
Comment thread esp/src/src-react/components/cards/DiskUsageCard.tsx
@GordonSmith GordonSmith force-pushed the HPCC-25201-REACT_ACTIVITIES branch from 6627a51 to 4051b83 Compare September 17, 2025 07:42
@GordonSmith GordonSmith requested a review from jeclrsg September 17, 2025 07:42
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith I added a nitpick comment about a duplicate import I didn't notice earlier, but also just going ahead and marking as approved

Comment thread esp/src/src-react/components/cards/QueueCard.tsx Outdated
Signed-off-by Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith force-pushed the HPCC-25201-REACT_ACTIVITIES branch from 4051b83 to 8b77d24 Compare September 18, 2025 15:01
@GordonSmith GordonSmith merged commit 38bfbf0 into hpcc-systems:candidate-9.8.x Sep 18, 2025
15 of 16 checks passed
@GordonSmith GordonSmith deleted the HPCC-25201-REACT_ACTIVITIES branch September 18, 2025 15:01
@github-actions
Copy link
Copy Markdown

Jirabot Action Result:
Added fix version: 9.8.120
Added fix version: 9.10.66
Added fix version: 9.12.40
Added fix version: 9.14.22
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants