HPCC-25201 Add React Activities#20356
Conversation
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-25201 Jirabot Action Result: |
There was a problem hiding this comment.
Pull Request Overview
This PR adds React-based Activities component cards as a preview feature to the ECL Watch web interface. It introduces new card-based visualizations for activities, disk usage, and queue management alongside the existing activities view.
- Adds new
/activities-previewroute with React card-based UI components - Implements reusable card components for queues, disk usage, and activities
- Extracts shared utility functions from ESPDFUWorkunit for better code reuse
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| esp/src/tests/v9-activities-preview.spec.ts | Adds Playwright tests for the new activities preview page |
| esp/src/tests/test-wus.json | Removes test workunit configuration file |
| esp/src/src/ESPDFUWorkunit.ts | Extracts state and protection image utility functions for reuse |
| esp/src/src/DiskUsage.ts | Adds ClusterGauge class for disk usage visualization |
| esp/src/src-react/util/metricGraph.ts | Updates CSS import path for React styling |
| esp/src/src-react/routes.tsx | Adds new activities-preview route |
| esp/src/src-react/hooks/queue.ts | Implements queue management hooks and types |
| esp/src/src-react/hooks/index.ts | Exports new queue hooks |
| esp/src/src-react/hooks/diskUsage.ts | Adds disk usage data hooks |
| esp/src/src-react/hooks/banner.tsx | Updates activity hook usage pattern |
| esp/src/src-react/hooks/activity.ts | Refactors activity hook return value and improves type safety |
| esp/src/src-react/components/controls/OverflowMenu.tsx | Enhances menu button styling |
| esp/src/src-react/components/controls/FlatTreeEx.tsx | Updates React.FC to React.FunctionComponent |
| esp/src/src-react/components/cards/QueueCard.tsx | Implements queue management card component |
| esp/src/src-react/components/cards/GenericCard.tsx | Creates reusable card component foundation |
| esp/src/src-react/components/cards/DiskUsageCard.tsx | Implements disk usage visualization cards |
| esp/src/src-react/components/cards/CardGroup.tsx | Creates grid layout component for cards |
| esp/src/src-react/components/Menu.tsx | Adds activities preview menu item |
| esp/src/src-react/components/DiskUsage.tsx | Refactors disk usage component to use cards |
| esp/src/src-react/components/ActivitiesCards.tsx | Implements main activities preview page |
| esp/src/src-dojo/nls/hpcc.ts | Adds new localization strings |
| esp/src/.gitignore | Adds test-wus.json to gitignore |
| esp/src/.github/instructions/react-coding.instructions.md | Updates React component type preference |
8ece48b to
6627a51
Compare
|
@jeclrsg this is the same PR as previously, except its a tech preview rather than marking the other as legacy. |
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith looked good. All my comments were just nitpicks. Copilot still had a comment that was unaddressed. Don't remember which file, but it was just suggesting includes() over indexOf() somewhere
| pushClusters(activity?.HThorClusterList?.TargetCluster, 1); | ||
| pushClusters(activity?.RoxieClusterList?.TargetCluster, 2); | ||
| pushClusters(activity?.ThorClusterList?.TargetCluster, 3); |
There was a problem hiding this comment.
add an enum for these ints? or is there such a thing already somewhere in comms maybe?
6627a51 to
4051b83
Compare
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith I added a nitpick comment about a duplicate import I didn't notice earlier, but also just going ahead and marking as approved
Signed-off-by Gordon Smith <GordonJSmith@gmail.com>
4051b83 to
8b77d24
Compare
38bfbf0
into
hpcc-systems:candidate-9.8.x
|
Jirabot Action Result: |
Signed-off-by Gordon Smith GordonJSmith@gmail.com
Type of change:
Checklist:
Smoketest:
Testing: