Record Thor manager pod info early; preserve connected worker pod names on registration timeout#21155
Draft
Copilot wants to merge 2 commits intocandidate-10.2.xfrom
Draft
Record Thor manager pod info early; preserve connected worker pod names on registration timeout#21155Copilot wants to merge 2 commits intocandidate-10.2.xfrom
Copilot wants to merge 2 commits intocandidate-10.2.xfrom
Conversation
…ecorded on timeout Co-authored-by: jakesmith <902700+jakesmith@users.noreply.github.com> Agent-Logs-Url: https://github.com/hpcc-systems/HPCC-Platform/sessions/9847c7cc-7e7b-40e3-b24d-e9618b987743
Copilot
AI
changed the title
[WIP] Update pod name publishing to include early thor manager info
Record Thor manager pod info early; preserve connected worker pod names on registration timeout
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In containerized Thor, pod names (manager + workers) were only published to the workunit after all workers had fully registered. A registration timeout caused no pod info to be recorded at all.
Changes
thgraphmanager.hpp/thgraphmanager.cpppublishPodNames()into two focused functions:publishManagerPodName(workunit, graphName)— records the Thor manager pod immediately; also associates the graph name on subsequent calls (replacing thethorMainuse ofpublishPodNames)publishWorkerPodNames(workunit, workers)— records worker pod names and stores them in the staticconnectedWorkersfor future graph-name associationsthmastermain.cpp—CRegistryServer::connect()publishManagerPodNamebefore the worker registration wait loopwhileloop in atry/catchso that whatever workers did connect are passed topublishWorkerPodNamesregardless of a timeout exceptionStWhenK8sReadytimestamp is only recorded on full success (no change in semantics)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
downloads.apache.org/usr/bin/curl curl --fail --retry 3 -L REDACTED --create-dirs --output apr-1.7.6.tar.bz2.7502.part -H User-Agent: vcpkg/2025-09-03-4580816534ed8fd9634ac83d46471440edd82dfe (curl) as nwin�� r-strong conftest.o /home/REDACTED/wor.deps/antlr3debughandlers.Tpo h include/antlr3commontoken.h include/antlr3commontree.h include/antlr3commontreeadaptor.h incl --local /opt/pipx_bin/gi. as(dns block)/usr/bin/curl curl --fail --retry 3 -L REDACTED --create-dirs --output apr-1.7.6.tar.bz2.8220.part -H User-Agent: vcpkg/2025-09-03-4580816534ed8fd9634ac83d46471440edd82dfe (curl) rm -f core conftest.err -linux-x86_64/bin/cmake conftest.c -c .o es -D_VCPKG_INS(dns block)If you need me to access, download, or install something from one of these locations, you can either:
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.