Skip to content

Commit 28f2cdb

Browse files
authored
fix(comms): empty values passed to WsLogaccess.GetLogs (#4517)
fixes an issue where empty values being passed to GetLogs was breaking filter construction Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
1 parent 9959552 commit 28f2cdb

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/comms/src/services/wsLogaccess.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,14 @@ export class LogaccessService extends LogaccessServiceBase {
118118
};
119119

120120
const filters: WsLogaccess.leftFilter[] = [];
121+
const logTypes = Object.values(WsLogaccess.LogColumnType);
121122
for (const key in request) {
123+
if (request[key] == null || request[key] === "" || (Array.isArray(request[key]) && request[key].length === 0)) {
124+
continue;
125+
}
122126
let searchField;
123127
if (key in columnMap) {
124-
if (Object.values(WsLogaccess.LogColumnType).includes(key as WsLogaccess.LogColumnType)) {
128+
if (logTypes.includes(key as WsLogaccess.LogColumnType)) {
125129
searchField = key;
126130
} else {
127131
searchField = columnMap[key];

0 commit comments

Comments
 (0)