Skip to content

Commit bee2a5c

Browse files
CopilotGordonSmith
andauthored
Bump @Lumino to latest version in packages/phosphor (#4424)
* Initial plan * Update Lumino packages to latest versions (v2.x) Co-authored-by: GordonSmith <966863+GordonSmith@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: GordonSmith <966863+GordonSmith@users.noreply.github.com>
1 parent ca3e257 commit bee2a5c

File tree

7 files changed

+170
-33
lines changed

7 files changed

+170
-33
lines changed

package-lock.json

Lines changed: 141 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/phosphor/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@
4141
},
4242
"devDependencies": {
4343
"@hpcc-js/esbuild-plugins": "^1.4.8",
44-
"@lumino/algorithm": "1.9.2",
45-
"@lumino/commands": "1.21.1",
46-
"@lumino/messaging": "1.10.3",
47-
"@lumino/widgets": "1.37.2"
44+
"@lumino/algorithm": "2.0.3",
45+
"@lumino/commands": "2.3.2",
46+
"@lumino/messaging": "2.0.3",
47+
"@lumino/widgets": "2.7.1"
4848
},
4949
"repository": {
5050
"type": "git",
Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
1-
.p-DockPanel-overlay {
1+
.lm-DockPanel-overlay {
22
background: rgba(255, 255, 255, 0.6);
33
border: 1px dashed black;
44
transition-property: top, left, right, bottom;
55
transition-duration: 150ms;
66
transition-timing-function: ease;
77
}
88

9-
.p-TabBar {
9+
.lm-TabBar {
1010
min-height: 24px;
1111
max-height: 24px;
1212
}
1313

14-
.p-TabBar-content {
14+
.lm-TabBar-content {
1515
min-width: 0;
1616
min-height: 0;
1717
align-items: flex-end;
1818
}
1919

20-
.p-TabPanel-tabBar .p-TabBar-content {
20+
.lm-TabPanel-tabBar .lm-TabBar-content {
2121
border-bottom: 1px solid #C0C0C0;
2222
}
2323

24-
.p-TabBar-tab {
24+
.lm-TabBar-tab {
2525
padding: 0px 10px;
2626
background: #E5E5E5;
2727
border: 1px solid #C0C0C0;
@@ -35,47 +35,47 @@
3535
line-height: 20px;
3636
}
3737

38-
.p-TabBar-tab.p-mod-current {
38+
.lm-TabBar-tab.lm-mod-current {
3939
background: white;
4040
}
4141

4242

43-
.p-TabBar-tab:hover:not(.p-mod-current) {
43+
.lm-TabBar-tab:hover:not(.lm-mod-current) {
4444
background: #F0F0F0;
4545
}
4646

4747

48-
.p-TabBar-tab:first-child {
48+
.lm-TabBar-tab:first-child {
4949
margin-left: 0;
5050
}
5151

5252

53-
.p-TabBar-tab.p-mod-current {
53+
.lm-TabBar-tab.lm-mod-current {
5454
min-height: 23px;
5555
max-height: 23px;
5656
transform: translateY(1px);
5757
}
5858

5959

60-
.p-TabBar-tabIcon,
61-
.p-TabBar-tabLabel,
62-
.p-TabBar-tabCloseIcon {
60+
.lm-TabBar-tabIcon,
61+
.lm-TabBar-tabLabel,
62+
.lm-TabBar-tabCloseIcon {
6363
display: inline-block;
6464
}
6565

6666

67-
.p-TabBar-tab.p-mod-closable > .p-TabBar-tabCloseIcon {
67+
.lm-TabBar-tab.lm-mod-closable>.lm-TabBar-tabCloseIcon {
6868
margin-left: 4px;
6969
}
7070

7171

72-
.p-TabBar-tab.p-mod-closable > .p-TabBar-tabCloseIcon:before {
72+
.lm-TabBar-tab.lm-mod-closable>.lm-TabBar-tabCloseIcon:before {
7373
content: '\f00d';
7474
font-family: FontAwesome;
7575
}
7676

7777

78-
.p-TabBar-tab.p-mod-drag-image {
78+
.lm-TabBar-tab.lm-mod-drag-image {
7979
min-height: 23px;
8080
max-height: 23px;
8181
min-width: 125px;
@@ -84,11 +84,11 @@
8484
transform: translateX(-40%) translateY(-58%);
8585
}
8686

87-
.p-Widget.p-TabBar.p-DockPanel-tabBar.hide {
87+
.lm-Widget.lm-TabBar.lm-DockPanel-tabBar.hide {
8888
min-height: 1px !important;
8989
max-height: 1px !important;
9090
}
9191

92-
.p-Widget.p-TabBar.p-DockPanel-tabBar.hide .p-TabBar-tab.p-mod-current {
92+
.lm-Widget.lm-TabBar.lm-DockPanel-tabBar.hide .lm-TabBar-tab.lm-mod-current {
9393
display: none;
94-
}
94+
}

packages/phosphor/src/DockPanel.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export class DockPanel extends HTMLWidget implements IMessageHandler, IMessageHo
9191
.style("overflow", "hidden")
9292
;
9393

94-
element.select(".p-Widget")
94+
element.select(".lm-Widget")
9595
.style("width", this._pPlaceholder.node().clientWidth + "px")
9696
.style("height", this.height() + "px")
9797
;
@@ -115,7 +115,7 @@ export class DockPanel extends HTMLWidget implements IMessageHandler, IMessageHo
115115
this._dock.content().watchRendered(this, callback);
116116
this._dock.update();
117117
setTimeout(() => {
118-
const tabBars = this.element().selectAll(".p-Widget.p-TabBar.p-DockPanel-tabBar");
118+
const tabBars = this.element().selectAll(".lm-Widget.lm-TabBar.lm-DockPanel-tabBar");
119119
let refit = false;
120120
tabBars.each(function (this: HTMLElement) {
121121
const tabBar = d3Select(this);

packages/phosphor/src/SplitPanel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export class SplitPanel extends HTMLWidget {
4949

5050
update(domNode, element) {
5151
super.update(domNode, element);
52-
element.select(".p-Widget")
52+
element.select(".lm-Widget")
5353
.style("width", this.width() + "px")
5454
.style("height", this.height() + "px")
5555
;

packages/phosphor/src/TabPanel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export class TabPanel extends HTMLWidget {
6464

6565
update(domNode, element) {
6666
super.update(domNode, element);
67-
element.select(".p-Widget")
67+
element.select(".lm-Widget")
6868
.style("width", this.width() + "px")
6969
.style("height", this.height() + "px")
7070
;

packages/phosphor/src/WidgetAdapter.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
min-height: 64px;
88
}
99

10-
.phosphor_WidgetAdapter.p-DockPanel-widget {
10+
.phosphor_WidgetAdapter.lm-DockPanel-widget {
1111
border-top: none;
1212
box-shadow: 0px -1px 0px rgba(0, 0, 0, 0.2), 1px 1px 2px rgba(0, 0, 0, 0.2);
1313
}
1414

15-
.phosphor_WidgetAdapter.p-SplitPanel-child {
15+
.phosphor_WidgetAdapter.lm-SplitPanel-child {
1616
border: none;
17-
}
17+
}

0 commit comments

Comments
 (0)