Skip to content

Commit caa7ea3

Browse files
committed
fix: esbuild options not passed on
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
1 parent 8afa398 commit caa7ea3

File tree

2 files changed

+18
-20
lines changed

2 files changed

+18
-20
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/esbuild-plugins/src/build.ts

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -109,56 +109,54 @@ export function browserTpl(input: string, output: string, options: TplOptions =
109109
target: "es2022",
110110
globalName: options.globalName,
111111
keepNames: options.keepNames,
112-
plugins: options.format === "umd" ? [umdWrapper({ libraryName: options.libraryName }), ...options.plugins ?? []] : [...options.plugins ?? []],
112+
plugins: options.format === "umd" ? [...options.plugins ?? [], umdWrapper({ libraryName: options.libraryName })] : options.plugins,
113113
alias: options.alias,
114114
define: options.define,
115115
loader: options.loader,
116+
supported: options.supported,
116117
});
117118
}
118119

119120
export function nodeTpl(input: string, output: string, options: TplOptions = {}) {
121+
options.format = options.format ?? "esm";
120122
options.packages = options.packages ?? "external";
121123
if (options.packages === "auto") {
122124
options.external = autoExternal(options.external);
123125
}
124126

125127
return buildWatch([input], {
126128
format: options.format === "umd" ? "esm" : options.format,
129+
external: options.external ?? [],
127130
outfile: `${output}.${options.format === "esm" ? NODE_MJS : NODE_CJS}`,
128131
platform: "node",
129132
target: "node22",
130133
packages: options.packages === "auto" ? "bundle" : options.packages,
134+
globalName: options.globalName,
135+
keepNames: options.keepNames,
136+
plugins: options.plugins,
137+
alias: options.alias,
138+
define: options.define,
139+
loader: options.loader,
140+
supported: options.supported,
131141
});
132142
}
133143

134144
export function neutralTpl(input: string, output: string, options: TplOptions = {}) {
135145
options.format = options.format ?? "esm";
136146

137-
let postfix = "";
138-
switch (options.format) {
139-
case "iife":
140-
postfix = "iife.js";
141-
break;
142-
case "esm":
143-
postfix = NODE_MJS;
144-
break;
145-
case "cjs":
146-
postfix = NODE_CJS;
147-
break;
148-
case "umd":
149-
postfix = "umd.js";
150-
break;
151-
default:
152-
throw new Error(`Unknown format: ${options.format}`);
153-
}
154147
return buildWatch([input], {
155148
format: options.format === "umd" ? "esm" : options.format,
149+
external: options.external ?? [],
156150
outfile: `${output}.${options.format === "esm" ? "js" : `${options.format}.js`}`,
157151
platform: "neutral",
158152
target: "es2022",
159153
globalName: options.globalName,
160154
keepNames: options.keepNames,
161-
plugins: options.format === "umd" ? [umdWrapper({ libraryName: options.libraryName })] : [] as Plugin[]
155+
plugins: options.format === "umd" ? [...options.plugins ?? [], umdWrapper({ libraryName: options.libraryName })] : options.plugins,
156+
alias: options.alias,
157+
define: options.define,
158+
loader: options.loader,
159+
supported: options.supported,
162160
});
163161
}
164162

0 commit comments

Comments
 (0)