fix: Dock panel scrollbars are illogical#4381
Merged
GordonSmith merged 1 commit intoJun 6, 2025
Merged
Conversation
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the placeholder styling in the DockPanel to prevent unnecessary scrollbars from appearing.
- Changed placeholder overflow style from
autotohidden - Ensures scrollbars no longer appear when content fits within the panel
Comments suppressed due to low confidence (1)
packages/phosphor/src/DockPanel.ts:91
- [nitpick] Consider adding a brief comment explaining why the overflow is set to 'hidden' here, so future maintainers understand the rationale for removing scrollbars.
.style("overflow", "hidden")
jeclrsg
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: