Skip to content

fix: Dock panel scrollbars are illogical#4381

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:DOCK_PANEL_OVERFLOW
Jun 6, 2025
Merged

fix: Dock panel scrollbars are illogical#4381
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:DOCK_PANEL_OVERFLOW

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Jun 6, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith requested a review from Copilot June 6, 2025 10:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the placeholder styling in the DockPanel to prevent unnecessary scrollbars from appearing.

  • Changed placeholder overflow style from auto to hidden
  • Ensures scrollbars no longer appear when content fits within the panel
Comments suppressed due to low confidence (1)

packages/phosphor/src/DockPanel.ts:91

  • [nitpick] Consider adding a brief comment explaining why the overflow is set to 'hidden' here, so future maintainers understand the rationale for removing scrollbars.
.style("overflow", "hidden")

@GordonSmith GordonSmith requested a review from jeclrsg June 6, 2025 10:31
@GordonSmith GordonSmith merged commit e3052e2 into hpcc-systems:candidate-3.x.x Jun 6, 2025
1 check passed
@GordonSmith GordonSmith deleted the DOCK_PANEL_OVERFLOW branch June 6, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants