Skip to content

fix: Sourcemaps out of sync#4399

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:SOURCE_MAPS
Jun 24, 2025
Merged

fix: Sourcemaps out of sync#4399
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:SOURCE_MAPS

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Jun 23, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested review from Copilot and jeclrsg June 23, 2025 16:27

This comment was marked as outdated.

},
plugins: [
cssInjectedByJsPlugin()
cssInjectedByJsPlugin({
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A reasonable comment; I think you could take it even further and say (almost?) all of these config files are exactly the same, completely. So, maybe pull the whole thing out into something, maybe in that esbuild-plugins package? Not now, just saying for future reference.

This comment was marked as outdated.

@GordonSmith GordonSmith force-pushed the SOURCE_MAPS branch 2 times, most recently from 7cd8424 to 77a8966 Compare June 24, 2025 11:36
@GordonSmith GordonSmith requested a review from Copilot June 24, 2025 11:46

This comment was marked as outdated.

@GordonSmith GordonSmith requested a review from jeclrsg June 24, 2025 11:53
@GordonSmith
Copy link
Copy Markdown
Member Author

Tests all passed, but seems to have stalled on that step...

Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith noticed a few of the config.ts files that had specific differences from all the others

Comment thread packages/graph/vite.config.ts
Comment thread packages/react/vite.config.ts
Comment thread packages/dgrid/vite.config.ts
Comment thread packages/dgrid2/vite.config.ts
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses sourcemap synchronization issues by refactoring the individual Vite configuration files across packages to use the new createHpccViteConfig helper from @hpcc-js/esbuild-plugins and by standardizing test setups. Key changes include:

  • Replacing custom Vite configurations in nearly all packages with the createHpccViteConfig function.
  • Setting test files’ urlSearch variables to an empty string.
  • Updating dependency versions and related configuration details in package.json and the esbuild-plugins package.

Reviewed Changes

Copilot reviewed 47 out of 48 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/util/vite.config.ts Refactored to use createHpccViteConfig
packages/tree/vite.config.ts Refactored to use createHpccViteConfig
packages/tree/tests/tree.browser.spec.ts Changed urlSearch assignment to an empty string
packages/timeline/vite.config.ts Refactored to use createHpccViteConfig
packages/timeline/tests/timeline.browser.spec.ts Changed urlSearch assignment to an empty string
packages/react/vite.config.ts Refactored to use createHpccViteConfig with preact plugin integration
packages/react/tests/react.browser.spec.ts Changed urlSearch assignment to an empty string
packages/phosphor/vite.config.ts Refactored to use createHpccViteConfig
packages/phosphor/tests/phosphor.browser.spec.ts Changed urlSearch assignment to an empty string
packages/other/vite.config.ts Refactored to use createHpccViteConfig
packages/other/tests/other.browser.spec.ts Changed urlSearch assignment to an empty string
packages/other/src/Comms.ts Removed obsolete self-assignment workaround comment
packages/observablehq-compiler/vite.config.ts Refactored to use createHpccViteConfig
packages/markdown-it-plugins/vite.config.ts Refactored to use createHpccViteConfig
packages/map/vite.config.ts Refactored to use createHpccViteConfig
packages/map/tests/map.browser.spec.ts Changed urlSearch assignment to an empty string
packages/layout/vite.config.ts Refactored to use createHpccViteConfig
packages/layout/tests/layout.browser.spec.ts Changed urlSearch assignment to an empty string
packages/html/vite.config.ts Refactored to use createHpccViteConfig
packages/html/tests/html.browser.spec.ts Changed urlSearch assignment to an empty string
packages/graph/vite.config.ts Refactored to use createHpccViteConfig with external overrides
packages/graph/tests/graph.browser.spec.ts Changed urlSearch assignment to an empty string
packages/form/vite.config.ts Refactored to use createHpccViteConfig
packages/form/tests/form.browser.spec.ts Changed urlSearch assignment to an empty string
packages/esbuild-plugins/src/vite-utils.ts Enhanced createHpccViteConfig functionality and options support
packages/esbuild-plugins/package.json Updated dependency versions for Vite and related plugins
packages/eclwatch/vite.config.ts Refactored to use createHpccViteConfig
packages/eclwatch/tests/eclwatch.browser.spec.ts Changed urlSearch assignment to an empty string
packages/dgrid2/vite.config.ts Refactored to use createHpccViteConfig with react plugin integration
packages/dgrid2/tests/dgrid2.browser.spec.ts Changed urlSearch assignment to an empty string
packages/dgrid/vite.config.ts Refactored to use createHpccViteConfig with configOverrides
packages/dgrid-shim/src/loaderConfig.js Minor whitespace adjustment
packages/ddl-shim/vite.config.ts Refactored to use createHpccViteConfig
packages/dataflow/vite.config.ts Refactored to use createHpccViteConfig
packages/composite/vite.config.ts Refactored to use createHpccViteConfig
packages/composite/tests/composite.browser.spec.ts Changed urlSearch assignment to an empty string
packages/comms/vite.config.ts Refactored to use createHpccViteConfig with a custom entry point
packages/common/vite.config.ts Refactored to use createHpccViteConfig with font-awesome integration
packages/common/tests/common.browser.spec.ts Changed urlSearch assignment to an empty string
packages/codemirror/vite.config.ts Refactored to use createHpccViteConfig
packages/codemirror/tests/codemirror.browser.spec.ts Changed urlSearch assignment to an empty string
packages/chart/vite.config.ts Refactored to use createHpccViteConfig
packages/chart/tests/chart.browser.spec.ts Changed urlSearch assignment to an empty string
packages/api/vite.config.ts Refactored to use createHpccViteConfig
packages/api/src/Tooltip.ts Removed redundant eslint-disable comments
package.json Upgraded vitest and updated dependency versions
demos/gallery/vite.config.ts Tweaked cssInjectedByJsPlugin configuration
Comments suppressed due to low confidence (1)

packages/tree/tests/tree.browser.spec.ts:7

  • The extraction of URL query parameters has been replaced with an empty string. Please verify that tests which depended on non-empty URL search values are still adequately covered.
const urlSearch: string = "";

@GordonSmith GordonSmith merged commit c46b154 into hpcc-systems:candidate-3.x.x Jun 24, 2025
1 check passed
@GordonSmith GordonSmith deleted the SOURCE_MAPS branch June 24, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants