Skip to content

fix: ecl-lang getting overwritten by vite#4402

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:ECL_LANG_EXPORT
Jun 26, 2025
Merged

fix: ecl-lang getting overwritten by vite#4402
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:ECL_LANG_EXPORT

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Jun 26, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith requested review from Copilot and jeclrsg June 26, 2025 10:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the build process for the markdown-it-plugins package and cleans up the Esbuild plugin imports to avoid unused references.

  • Use npm-run-all to run type generation and bundling with explicit parallel/serial ordering.
  • Remove the unused browserTpl import from the Esbuild configuration.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/markdown-it-plugins/package.json Updated the build script to use npm-run-all with --parallel and --serial flags.
packages/markdown-it-plugins/esbuild.js Removed the browserTpl import, leaving only nodeTpl.
Comments suppressed due to low confidence (2)

packages/markdown-it-plugins/package.json:40

  • [nitpick] Running gen-types and bundle in parallel may introduce a race condition if bundling depends on freshly generated types. Consider sequencing gen-types before bundle, or verify that bundle does not rely on type outputs produced at build time.
        "build": "npm-run-all --parallel gen-types bundle --serial bundle2",

packages/markdown-it-plugins/esbuild.js:1

  • If browserTpl is still referenced in the Promise.all call below, removing its import will cause a runtime error. Ensure you either remove its usage or re-import browserTpl where needed.
import { nodeTpl } from "@hpcc-js/esbuild-plugins";

@GordonSmith GordonSmith merged commit 642f418 into hpcc-systems:candidate-3.x.x Jun 26, 2025
1 check passed
@GordonSmith GordonSmith changed the title fix: ecl-lang getting overwritten bye vite fix: ecl-lang getting overwritten by vite Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants