fix: ecl-lang getting overwritten by vite#4402
Merged
GordonSmith merged 1 commit intoJun 26, 2025
Merged
Conversation
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the build process for the markdown-it-plugins package and cleans up the Esbuild plugin imports to avoid unused references.
- Use
npm-run-allto run type generation and bundling with explicit parallel/serial ordering. - Remove the unused
browserTplimport from the Esbuild configuration.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/markdown-it-plugins/package.json | Updated the build script to use npm-run-all with --parallel and --serial flags. |
| packages/markdown-it-plugins/esbuild.js | Removed the browserTpl import, leaving only nodeTpl. |
Comments suppressed due to low confidence (2)
packages/markdown-it-plugins/package.json:40
- [nitpick] Running
gen-typesandbundlein parallel may introduce a race condition if bundling depends on freshly generated types. Consider sequencinggen-typesbeforebundle, or verify thatbundledoes not rely on type outputs produced at build time.
"build": "npm-run-all --parallel gen-types bundle --serial bundle2",
packages/markdown-it-plugins/esbuild.js:1
- If
browserTplis still referenced in thePromise.allcall below, removing its import will cause a runtime error. Ensure you either remove its usage or re-importbrowserTplwhere needed.
import { nodeTpl } from "@hpcc-js/esbuild-plugins";
jeclrsg
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: