fix: Improve type-leaks test#4405
Closed
GordonSmith wants to merge 1 commit into
Closed
Conversation
cd52bad to
27e27c5
Compare
Was missing some node deps still in devDeps Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
27e27c5 to
16ac217
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the type-leaks test suite by refining type reference extraction and ensuring that required node dependencies are properly categorized. Key changes include updating import statements to use the node: prefix, enhancing regex fallback patterns for export statements, and adjusting dependency locations in package.json files.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/type-leaks/type-dependencies.spec.ts | Updates test logic for type reference extraction, adds ESM‑friendly __dirname, and enhances regex usage. |
| packages/markdown-it-plugins/package.json | Adjusts dependency categorization by moving some node dependencies from devDependencies to peerDependencies. |
| packages/comms/src/index.node.ts | Fixes the https module import to use "node:https" as per updated Node.js conventions. |
| packages/comms/src/clienttools/eclcc.ts | Changes built‐in module imports to use node: prefixes. |
| packages/comms/src/clienttools/eclMeta.ts | Updates built‐in module imports to use node: prefixes. |
| packages/comms/package.json | Adds missing runtime dependency declarations and reorders devDependencies accordingly. |
Comments suppressed due to low confidence (2)
packages/markdown-it-plugins/package.json:61
- Verify that moving 'apache-arrow' and adding 'shiki' to peerDependencies (instead of devDependencies) is intentional and aligns with the usage within the package.
"apache-arrow": "19.0.1",
tests/type-leaks/type-dependencies.spec.ts:379
- Ensure that 'tsFile' is an absolute path as returned by glob and that extractTypeReferences handles absolute paths as expected.
const typeRefs = extractTypeReferences(tsFile);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was missing some node deps still in devDeps
Checklist:
Testing: