Skip to content

fix: Improve type-leaks test#4405

Closed
GordonSmith wants to merge 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:LEAK_TESTS_II
Closed

fix: Improve type-leaks test#4405
GordonSmith wants to merge 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:LEAK_TESTS_II

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Jun 27, 2025

Was missing some node deps still in devDeps

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from Copilot June 27, 2025 12:29

This comment was marked as outdated.

This comment was marked as outdated.

Was missing some node deps still in devDeps

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the type-leaks test suite by refining type reference extraction and ensuring that required node dependencies are properly categorized. Key changes include updating import statements to use the node: prefix, enhancing regex fallback patterns for export statements, and adjusting dependency locations in package.json files.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/type-leaks/type-dependencies.spec.ts Updates test logic for type reference extraction, adds ESM‑friendly __dirname, and enhances regex usage.
packages/markdown-it-plugins/package.json Adjusts dependency categorization by moving some node dependencies from devDependencies to peerDependencies.
packages/comms/src/index.node.ts Fixes the https module import to use "node:https" as per updated Node.js conventions.
packages/comms/src/clienttools/eclcc.ts Changes built‐in module imports to use node: prefixes.
packages/comms/src/clienttools/eclMeta.ts Updates built‐in module imports to use node: prefixes.
packages/comms/package.json Adds missing runtime dependency declarations and reorders devDependencies accordingly.
Comments suppressed due to low confidence (2)

packages/markdown-it-plugins/package.json:61

  • Verify that moving 'apache-arrow' and adding 'shiki' to peerDependencies (instead of devDependencies) is intentional and aligns with the usage within the package.
        "apache-arrow": "19.0.1",

tests/type-leaks/type-dependencies.spec.ts:379

  • Ensure that 'tsFile' is an absolute path as returned by glob and that extractTypeReferences handles absolute paths as expected.
                    const typeRefs = extractTypeReferences(tsFile);

Comment thread tests/type-leaks/type-dependencies.spec.ts
@GordonSmith GordonSmith marked this pull request as draft June 27, 2025 14:19
@GordonSmith GordonSmith deleted the LEAK_TESTS_II branch June 30, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants