Skip to content

fix: Improve type-leaks test#4406

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:LEAK_TESTS_III
Jul 2, 2025
Merged

fix: Improve type-leaks test#4406
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:LEAK_TESTS_III

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Jun 30, 2025

Was missing some node deps still in devDeps

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from Copilot June 30, 2025 12:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request augments the type-leaks test suite, ensures the tests/** folder is included in Vitest’s workspace, and refactors several build and dependency configurations across packages.

  • Include the tests/** directory in Vitest’s workspace settings
  • Enhance the type-leaks test to detect exports, dynamic imports, and resolve package paths via import.meta.url
  • Refactor build scripts: adopt node:-prefixed core imports, unify esbuild plugin exports, and update dependency declarations

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vitest.workspace.ts Added "tests/**" to workspace include patterns
tests/type-leaks/type-dependencies.spec.ts Enhanced logic to capture export declarations and compute PACKAGES_DIR
tests/package.json Introduced a test orchestrator package.json for running all test suites
packages/util/esbuild.js Removed obsolete build script
packages/markdown-it-plugins/package.json Moved apache-arrow and shiki from devDependencies to peerDependencies
packages/markdown-it-plugins/esbuild.js Bundling config now externalizes both dependencies and peerDependencies
packages/esbuild-plugins/src/build.ts Refactored buildWatch API, added autoExternal, exported copyStaticFiles
packages/comms/src/index.node.ts Switched import from "https" to "node:https"
packages/comms/src/ecl/scope.ts Removed commented-out D3 time-format imports and unused variables
packages/comms/src/clienttools/eclcc.ts Switched core imports to node:child_process, node:fs, etc.
packages/comms/src/clienttools/eclMeta.ts Switched core imports to node:fs and node:path
packages/comms/esbuild.js Added packages: "bundle" option to nodeBoth bundling for comms
package.json (root) Added @types/esbuild-copy-static-files to devDependencies
Comments suppressed due to low confidence (3)

packages/esbuild-plugins/src/build.ts:7

  • The default export from esbuild-copy-static-files may not be correctly imported as a namespace; switch to import copyStaticFiles from "esbuild-copy-static-files" or verify the module’s export shape to ensure the plugin loads properly.
import * as copyStaticFiles from "esbuild-copy-static-files";

packages/esbuild-plugins/src/build.ts:62

  • [nitpick] This debug statement prints the entire build configuration; consider removing it or using a debug-level logger to keep build output concise.
    console.log("config", config);

Was missing some node deps still in devDeps

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 379961d into hpcc-systems:candidate-3.x.x Jul 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants