feat: Add recursiveFetchLogicalFiles#4407
Merged
GordonSmith merged 1 commit intoJul 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new recursiveFetchLogicalFiles method to enhance the DFUService by recursively retrieving logical file information. Key changes include:
- Adding the recursiveFetchLogicalFiles function in DFUService for fetching logical files recursively.
- Extending the LogicalFile class with a fetchAllLogicalFiles method that utilizes the new recursive function.
- Including a new (currently skipped) test case to validate the recursive fetching behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/comms/tests/wsDFU.spec.ts | Added a skipped test for recursive fetching of logical files. |
| packages/comms/src/services/wsDFU.ts | Introduced recursiveFetchLogicalFiles to recursively fetch logical files. |
| packages/comms/src/ecl/logicalFile.ts | Added a convenience method that wraps the new recursive fetching logic. |
Comments suppressed due to low confidence (3)
packages/comms/src/services/wsDFU.ts:18
- The recursiveFetchLogicalFiles method expects objects with 'NodeGroup' and 'Name' properties, but the recursive call uses 'childSuperFiles', whose type may not fully align. Consider unifying the data types or mapping the LogicalFile instance properly before recursion.
async recursiveFetchLogicalFiles(superFiles: { NodeGroup: string, Name: string }[]): Promise<string[]> {
packages/comms/src/ecl/logicalFile.ts:180
- Passing 'this' (a LogicalFile instance) into recursiveFetchLogicalFiles may lead to a type mismatch if LogicalFile doesn't exactly match { NodeGroup: string, Name: string }. Consider mapping 'this' to the expected shape.
return this.connection.recursiveFetchLogicalFiles([this]);
packages/comms/tests/wsDFU.spec.ts:24
- [nitpick] The test for recursiveFetch is currently skipped; please re-enable it once the functionality is stable to ensure comprehensive test coverage for the new recursive fetching behavior.
it.skip("recursiveFetch", async function () {
Member
Author
|
@jeclrsg can you review |
jeclrsg
requested changes
Jul 2, 2025
Contributor
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith asked about the new test being marked as to be skipped
Fixes hpcc-systems#4392 Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
d5475c1 to
9ade578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4392
Checklist:
Testing: