feat: Add @observablehq/notebook-kit support#4439
Merged
Merged
Conversation
Member
Author
|
@jeclrsg ready for review... |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for @observablehq/notebook-kit integration to the observablehq-compiler package. It introduces new compilation pathways and utilities to work with the notebook-kit runtime system.
Key changes:
- Adds @observablehq/notebook-kit as a dependency and integrates its runtime capabilities
- Implements new compiler functions to support notebook-kit format alongside existing Observable formats
- Adds comprehensive test coverage with sample HTML notebooks demonstrating the new functionality
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Configures build system with npm/jsr import resolution and top-level await support |
| tests/index-notebookkit.ts | Adds comprehensive test suite for notebook-kit integration with HTML, OMD, and OJS formats |
| src/util.ts | Extends utilities with notebook-kit conversion functions and function constructor improvements |
| src/compiler.ts | Adds compileKit function and overloaded compile methods for notebook-kit support |
| src/index.ts | Exports new notebook-kit related functions |
| package.json | Adds notebook-kit and related dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Member
Author
|
...rebased and passing tests.... |
jeclrsg
reviewed
Aug 25, 2025
Contributor
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith only thing I wanted to double-check about was that case in vite.config.ts for jquery ui. Would approve otherwise.
jeclrsg
approved these changes
Aug 25, 2025
GordonSmith
added a commit
that referenced
this pull request
Aug 26, 2025
feat: Add @observablehq/notebook-kit support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: