feat: Bump observablehq runtime support#4444
Merged
Merged
Conversation
GordonSmith
commented
Sep 3, 2025
| @@ -0,0 +1,4 @@ | |||
| export * from "./util.ts"; | |||
| // export * from "./jsSerializer.ts"; | |||
1a392fa to
04b6a88
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the observablehq runtime support by transitioning from an older implementation to a newer, streamlined approach. The changes remove dependencies on top-level await plugins and related build configurations while adding a custom runtime implementation.
Key changes include:
- Simplified Vite configuration by removing top-level await plugin and related build settings
- Added a new runtime entry point for notebook kit functionality
- Updated test files to use the new runtime implementation and simplified test structure
Reviewed Changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/observablehq-compiler/vite.config.ts |
Removes top-level await plugin configuration and adds new runtime build entry |
packages/observablehq-compiler/tsconfig.json |
Includes new runtime source file in TypeScript compilation |
packages/observablehq-compiler/tests/system-guide.txt |
Adds new test content for system guide functionality |
packages/observablehq-compiler/tests/index-notebookkit.ts |
Refactors to use new runtime implementation and simplified test structure |
packages/observablehq-compiler/tests/index-notebookkit.js |
New JavaScript test file with embedded HTML content |
packages/observablehq-compiler/tests/albers-usa-projection.txt |
Adds new test content for projection functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
7aacf14 to
43a1c09
Compare
jeclrsg
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: