Skip to content

feat: Bump observablehq runtime support#4444

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:OHQ_BUMP
Sep 3, 2025
Merged

feat: Bump observablehq runtime support#4444
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:OHQ_BUMP

Conversation

@GordonSmith

@GordonSmith GordonSmith commented Sep 3, 2025

Copy link
Copy Markdown
Member

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from Copilot September 3, 2025 15:02
@@ -0,0 +1,4 @@
export * from "./util.ts";
// export * from "./jsSerializer.ts";

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments code

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the observablehq runtime support by transitioning from an older implementation to a newer, streamlined approach. The changes remove dependencies on top-level await plugins and related build configurations while adding a custom runtime implementation.

Key changes include:

  • Simplified Vite configuration by removing top-level await plugin and related build settings
  • Added a new runtime entry point for notebook kit functionality
  • Updated test files to use the new runtime implementation and simplified test structure

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/observablehq-compiler/vite.config.ts Removes top-level await plugin configuration and adds new runtime build entry
packages/observablehq-compiler/tsconfig.json Includes new runtime source file in TypeScript compilation
packages/observablehq-compiler/tests/system-guide.txt Adds new test content for system guide functionality
packages/observablehq-compiler/tests/index-notebookkit.ts Refactors to use new runtime implementation and simplified test structure
packages/observablehq-compiler/tests/index-notebookkit.js New JavaScript test file with embedded HTML content
packages/observablehq-compiler/tests/albers-usa-projection.txt Adds new test content for projection functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/observablehq-compiler/vite.config.ts Outdated
Comment thread packages/observablehq-compiler/tests/index-notebookkit.ts
@GordonSmith GordonSmith requested a review from jeclrsg September 3, 2025 15:13
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 0c2541d into hpcc-systems:candidate-3.x.x Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants