Skip to content

fix: improve runtime placeholder handling#4451

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:OHQ_UPDATE_FIX
Sep 18, 2025
Merged

fix: improve runtime placeholder handling#4451
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:OHQ_UPDATE_FIX

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Sep 10, 2025

Fixes previous issues with update and remove

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from Copilot September 10, 2025 06:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves runtime placeholder handling in the observablehq-compiler package by refactoring the API to better manage cell lifecycle operations. The changes rename functions for consistency and enhance error handling for cell operations.

  • Renamed compileKit to compileNotebook for better naming consistency
  • Enhanced runtime cell management with improved add/update/remove operations
  • Added proper error handling for cell state management

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/observablehq-compiler/tests/index-notebookkit.ts Updates import and function call to use new compileNotebook name
packages/observablehq-compiler/tests/index-notebookkit.js Updates import and function call to use new compileNotebook name
packages/observablehq-compiler/src/kit/runtime.ts Major refactor of cell management methods with better error handling
packages/observablehq-compiler/src/kit/index.ts Reorders exports
packages/observablehq-compiler/src/kit/compiler.ts Refactors compilation logic and renames functions
packages/observablehq-compiler/src/index.ts Updates exports to use new function names
packages/observablehq-compiler/src/compiler.ts Updates function call to use new compileNotebook name
packages/observablehq-compiler/index-kit.html Uncomments CSS styles

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/observablehq-compiler/src/kit/runtime.ts
Comment thread packages/observablehq-compiler/src/kit/runtime.ts
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/observablehq-compiler/src/kit/compiler.ts
Comment thread packages/observablehq-compiler/src/kit/compiler.ts Outdated
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith I didn't have anything to add; couple of pending copilot comments however

Fixes previous issues with update and remove

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit a3e8afb into hpcc-systems:candidate-3.x.x Sep 18, 2025
1 check failed
@GordonSmith GordonSmith deleted the OHQ_UPDATE_FIX branch September 18, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants