feat: bump wsdl versions#4454
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates WSDL versions across multiple services to align with newer API versions. It consolidates the interface definitions to use generated WSDL files and modernizes the service implementations by replacing direct interface definitions with imports from versioned WSDL namespaces.
- Upgrades several WSDL service versions (wsstore v1.02, ws_machine v1.18, WsPackageProcess v1.07, etc.)
- Refactors service implementations to extend from generated base classes instead of direct Service inheritance
- Standardizes method signatures to use
Partial<T>request types and proper response type mapping
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/comms/src/services/wsdl/wsstore/v1.02/wsstore.ts | Updates wsstore interface with simplified nested structures and modern method signatures |
| packages/comms/src/services/wsdl/ws_machine/v1.18/ws_machine.ts | Complete new WSDL file for machine service v1.18 with comprehensive interface definitions |
| packages/comms/src/services/wsdl/ws_elk/v1/ws_elk.ts | Minor updates to method signatures and additional spacing |
| packages/comms/src/services/wsdl/ws_codesign/v1.1/ws_codesign.ts | Restructured codesign service with enum updates and interface consolidation |
| packages/comms/src/services/wsdl/WsWorkunits/v2.02/WsWorkunits.ts | Adds new KeyCompression fields and updates Format field type |
| packages/comms/src/services/wsdl/WsTopology/v1.32/WsTopology.ts | Adds TpMachineType enum and simplifies nested interface structures |
| packages/comms/src/services/wsdl/WsSMC/v1.27/WsSMC.ts | Consolidates nested interface structures and updates method signatures |
| packages/comms/src/services/wsdl/WsPackageProcess/v1.07/WsPackageProcess.ts | Complete new WSDL file for package process service v1.07 |
| packages/comms/src/services/wsdl/WsFileIO/v1.01/WsFileIO.ts | Updates interface structure and method signatures |
| packages/comms/src/services/wsdl/WsDfu/v1.66/WsDfu.ts | Complete new WSDL file for DFU service v1.66 with extensive interface definitions |
| packages/comms/src/services/wsdl/WsDali/v1.07/WsDali.ts | Updates interface definitions and adds new field types |
| packages/comms/src/services/wsdl/WsDFUXRef/v1.04/WsDFUXRef.ts | Complete new WSDL file for DFUX reference service v1.04 |
| packages/comms/src/services/wsdl/FileSpray/v1.27/FileSpray.ts | Complete new WSDL file for file spray service v1.27 |
| packages/comms/src/services/wsWorkunits.ts | Removes commented code and unused imports |
| packages/comms/src/services/wsStore.ts | Refactors to extend from generated base class with simplified implementation |
| packages/comms/src/services/wsPackageProcess.ts | Updates import path to use v1.07 |
| packages/comms/src/services/wsMachine.ts | Updates import path to use v1.18 |
| packages/comms/src/services/wsDFUXRef.ts | Refactors to extend from generated base class |
| packages/comms/src/services/wsDFU.ts | Updates import path to use v1.66 |
| packages/comms/src/services/wsCodesign.ts | Refactors to extend from generated base class with enum usage |
| packages/comms/src/services/fileSpray.ts | Updates import path to use v1.27 |
| packages/comms/src/ecl/store.ts | Removes UserSpecific parameter from CreateStore call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| CustomColumns: CustomColumns; | ||
| ComponentsFilter: ComponentsFilter; | ||
| Format: LogAccessLogFormat; | ||
| Format: string; |
There was a problem hiding this comment.
The Format field type has been changed from 'LogAccessLogFormat' enum to 'string', which loosens type safety. This could lead to runtime errors if invalid format values are passed.
There was a problem hiding this comment.
This seems like it might not be right either, but it does reflect what the WSDL shows. In v2.01 this type was LogAccessLogFormat.
jeclrsg
left a comment
jeclrsg
left a comment
There was a problem hiding this comment.
The WsDali being off makes me a little nervous about all of them. But looking at random spots in some of the longer files, I didn't ever spot anything that was wrong; just seems weird it'd only be Dali.
| export interface AddRequest { | ||
| Path?: string; | ||
| Value?: string; | ||
| dstname?: string; |
There was a problem hiding this comment.
This isn't right. And I think the change to the DeleteRequest props isn't either
| CustomColumns: CustomColumns; | ||
| ComponentsFilter: ComponentsFilter; | ||
| Format: LogAccessLogFormat; | ||
| Format: string; |
There was a problem hiding this comment.
This seems like it might not be right either, but it does reflect what the WSDL shows. In v2.01 this type was LogAccessLogFormat.
| export type long = number; | ||
| export type unsignedInt = number; | ||
|
|
||
| export enum ThresholdType { |
There was a problem hiding this comment.
Were these two enums (ThresholdType and TpMachineType) added manually? Neither of them exist in the WSDL.
I guess I've never noticed that a WSDL can refer to a type that isn't defined in it? ie, the ws_machine WSDL has several properties that have a type="xsd:ThresholdType" even though no such type is defined in it.
There was a problem hiding this comment.
They were manually added
|
Also made me think I might start looking at using copilot to frame out some tests for any of these we don't already have |
GordonSmith
force-pushed
the
BUMP_WSDL_II
branch
2 times, most recently
from
d3f58ae to
6d13340
Compare
|
@jeclrsg I bumped the generation again so it includes the compression type (which is new from gavan). |
GordonSmith
force-pushed
the
BUMP_WSDL_II
branch
from
6d13340 to
69f74ad
Compare
|
Fixed minor lint issue |
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
BUMP_WSDL_II
branch
from
69f74ad to
8c27c44
Compare
Checklist:
Testing: