Skip to content

fix: NodeJS bundle invalid#4456

Merged
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:COMMS_NODE
Oct 9, 2025
Merged

fix: NodeJS bundle invalid#4456
GordonSmith merged 1 commit into
hpcc-systems:candidate-3.x.xfrom
GordonSmith:COMMS_NODE

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Oct 8, 2025

safe-buffer was using require

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from Copilot October 8, 2025 21:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a Node.js bundle issue by replacing the safe-buffer import with the native Node.js node:buffer module. This change addresses bundling problems that occurred when using the external safe-buffer dependency.

  • Replaced safe-buffer import with native Node.js node:buffer module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

safe-buffer was using require

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit b1388e5 into hpcc-systems:candidate-3.x.x Oct 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants