feat: enable chunking for SFX WASM builds#4499
Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom Jan 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables chunked processing for SFX (Self-Extracting) WASM builds to handle large WASM files more efficiently. The key improvement is the introduction of chunked encoding and compression instead of processing entire files in memory at once.
- Implements chunked processing for Base91 encoding and Zstd compression (64MB chunks)
- Optimizes the Base91 decode function with pre-allocated output buffers and lookup tables
- Updates dependencies to support chunked APIs (@hpcc-js/wasm-base91 1.10.0, @hpcc-js/wasm-zstd 1.9.0)
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/esbuild-plugins/src/sfx-wrapper.ts | Core implementation: adds chunked encoding/compression logic, optimizes decode function with pre-allocated buffers and lookup tables, updates imports to use node: prefix, adds singleton pattern for Base91/Zstd instances |
| packages/esbuild-plugins/package.json | Updates @hpcc-js/wasm-base91 to 1.10.0 and @hpcc-js/wasm-zstd to 1.9.0 to support chunked APIs; updates esbuild from 0.27.0 to 0.27.2; adds update-major script |
| package-lock.json | Reflects dependency updates including esbuild 0.27.2 and all platform-specific binaries, wasm library updates, and transitive dependency updates (js-yaml, mdast-util-to-hast) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gordon Smith<GordonJSmith@gmail.com>
f90bc70 to
f7519c5
Compare
jeclrsg
approved these changes
Jan 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: