feat: Add normalized global metrics support#4501
Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom Jan 7, 2026
Merged
feat: Add normalized global metrics support#4501GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith merged 1 commit intohpcc-systems:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for normalized global metrics in the HPCC Communications package by introducing a new method GetNormalisedGlobalMetrics that transforms raw metric data into a standardized format with proper type conversions for cost, date, numeric, and time values.
- Adds
GetNormalisedGlobalMetricsmethod toSMCServiceclass that normalizes metric data from the WsSMC service - Creates helper method
parseGlobalMetricto convert metric values based on field name prefixes - Updates HTML test page to demonstrate the new functionality with two examples
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/comms/src/services/wsSMC.ts | Adds NormalisedGlobalMetric interface, parseGlobalMetric helper method, and GetNormalisedGlobalMetrics method to transform and normalize global metrics data |
| packages/comms/tests/index.ts | Adds test function to analyze WUDetailsMeta field name prefixes for understanding metric naming patterns |
| packages/comms/index.html | Updates HTML test page with two test sections: one for WUDetailsMeta prefix analysis and one for demonstrating normalized global metrics retrieval |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
02c1263 to
38b9145
Compare
3389fb2 to
ee50942
Compare
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
ee50942 to
05ac96d
Compare
jeclrsg
approved these changes
Jan 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: