fix: drop deprecated node-fetch package#4503
Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom Jan 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the deprecated node-fetch (v3.3.2) and abort-controller (v3.0.0) packages from the @hpcc-js/comms package, updating the codebase to rely on native Node.js >= v18 implementations of fetch and AbortController. The change simplifies the dependency tree and modernizes the package for current Node.js versions.
Key changes:
- Removed polyfill-based implementations in favor of native Node.js APIs
- Added comprehensive test coverage for AbortController functionality
- Cleaned up package-lock.json to remove deprecated dependencies and their transitive dependencies
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/comms/tests/abortController.spec.ts |
New test file adding comprehensive coverage for AbortController functionality with various scenarios (immediate abort, delayed abort, multiple requests, GET/POST methods) |
packages/comms/src/index.node.ts |
Removed conditional polyfill imports for node-fetch and abort-controller, now assumes native Node.js >= v18 APIs are available |
packages/comms/package.json |
Removed node-fetch and abort-controller from dependencies |
package-lock.json |
Cleaned up dependency tree removing node-fetch, abort-controller, and their transitive dependencies (fetch-blob, formdata-polyfill, node-domexception, web-streams-polyfill, and various whatwg-url/webidl-conversions versions) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f1ea6e0 to
5846ce9
Compare
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
5846ce9 to
63511b8
Compare
jeclrsg
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: