Skip to content

fix: rejectAuthorize broken in VSCode ECL Extension#4512

Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith:REJECT_UNAUTH
Jan 26, 2026
Merged

fix: rejectAuthorize broken in VSCode ECL Extension#4512
GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith:REJECT_UNAUTH

Conversation

@GordonSmith
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith commented Jan 26, 2026 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith
fix: rejectAuthorize broken in VSCode ECL Extension
1e781d2 
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith requested a review from jeclrsg January 26, 2026 15:15
jeclrsg
jeclrsg requested changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith looked fine to me. Just that one question about the if you'd meant to change the ESP_URL in the testLib.ts

Comment thread packages/comms/tests/testLib.ts
import { isBrowser, isCI as utilIsTravis } from "@hpcc-js/util";

export const isCI = utilIsTravis;
// export const ESP_URL = isCI ? "https://play.hpccsystems.com:18010/" : "https://play.hpccsystems.com:18010/";
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this supposed to be commented out?

Copy link
Copy Markdown
Member Author

@GordonSmith GordonSmith Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its an alternative test server which we may want to use occasionally,

@GordonSmith GordonSmith merged commit 536ad22 into hpcc-systems:main Jan 26, 2026
3 checks passed
@GordonSmith GordonSmith deleted the REJECT_UNAUTH branch January 26, 2026 15:43
@github-actions github-actions bot mentioned this pull request Jan 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeclrsg jeclrsg jeclrsg requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GordonSmith @jeclrsg