Skip to content

chore(comms): bump the FileSpray service to v1.29 #4573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeclrsg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(comms): bump the FileSpray service to v1.29 #4573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions packages/comms/src/services/fileSpray.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FileSprayServiceBase, FileSpray } from "./wsdl/FileSpray/v1.27/FileSpray.ts";
import { FileSprayServiceBase, FileSpray } from "./wsdl/FileSpray/v1.29/FileSpray.ts";

export {
FileSpray
Expand All @@ -20,31 +20,6 @@ export enum FileSprayStates {
notfound = 999
}

// defined in https://github.com/hpcc-systems/HPCC-Platform/blob/master/dali/dfu/dfuwu.cpp#L102-L121
export enum DFUWUTypes {
Copy = "copy",
Remove = "remove",
Move = "move",
Rename = "rename",
Replicate = "replicate",
Import = "import",
Export = "export",
/*
* These seem to not be valid with respect to filtering DFU WUs,
* but leaving them here because they exist in the dfuwu.cpp struct
*
* Add = "add",
* Transfer = "transfer",
* Savemap = "savemap",
* Addgroup = "addgroup",
* Server = "server",
*/
Monitor = "monitor",
Copymerge = "copymerge",
Supercopy = "supercopy",
Publish = "publish",
}

Copy link
Copy Markdown
Member

@GordonSmith GordonSmith Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to keep these?

Copy link
Copy Markdown
Contributor Author

@jeclrsg jeclrsg Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They'll come out of the WSDL now, the DFUCommand on line 21 of the generated service. This one's kind of weird because it depends on the ESP changes in hpcc-systems/HPCC-Platform#21133 but also is a dependency of the UI changes in that PR

export interface UpdateDFUWorkunitEx extends UpdateDFUWorkunitMinusWU {
wu?: Partial<UpdateDFUWorkunitWU>
}
Expand Down
Loading
Loading