feat: reworked credential management#473
Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom Nov 20, 2025
Merged
Conversation
GordonSmith
force-pushed
the
BETTER_CREDS
branch
2 times, most recently
from
a360878 to
7e632f3
Compare
GordonSmith
commented
Nov 18, 2025
GordonSmith
force-pushed
the
BETTER_CREDS
branch
from
7e632f3 to
60d2534
Compare
Member
Author
|
@jeclrsg - this should be ready for review now... |
jeclrsg
suggested changes
Nov 19, 2025
Collaborator
jeclrsg
left a comment
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith all my comments were nitpicks I'd say, and possibly just because I misunderstood what should or shouldn't be passing through that localize util
Store passwords in the system keychain. Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
BETTER_CREDS
branch
from
60d2534 to
fe4c8c1
Compare
jeclrsg
approved these changes
Nov 20, 2025
Contributor
|
🎉 This change has been included in ecl-v2.33.0 🎉 The release is available on:
Your release-please bot 🚀🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store passwords in the system keychain.