chore: refactor ai/lm tools prior to adding new tools#476
Merged
GordonSmith merged 2 commits intohpcc-systems:mainfrom Dec 9, 2025
Merged
chore: refactor ai/lm tools prior to adding new tools#476GordonSmith merged 2 commits intohpcc-systems:mainfrom
GordonSmith merged 2 commits intohpcc-systems:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the AI/LM (Language Model) tools infrastructure in preparation for adding new tools. The refactoring improves code organization by moving tool implementations into a dedicated subdirectory, consolidating common utilities, and enhancing error handling and logging capabilities.
- Reorganized LM tools into
src/ecl/lm/tools/subdirectory with improved structure - Added new utility modules for session management, logging, and cancellation handling
- Enhanced tool implementations with better error messages, connection validation, and detailed output formatting
- Renamed tool IDs from underscore to hyphen convention for consistency
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hpccplatform/session.ts | Added options() method to Session class for creating IOptions objects from credentials |
| src/ecl/lm/utils/session.ts | New utility module providing session validation, options creation, and cancellation helpers |
| src/ecl/lm/utils/logger.ts | New logging utility for LM tool events with structured output channel |
| src/ecl/lm/utils/index.ts | Updated exports to include new session and logger utilities |
| src/ecl/lm/tools/syntaxCheck.ts | Moved and enhanced syntax checking tool with better error reporting and connection validation |
| src/ecl/lm/tools/findLogicalFiles.ts | Moved and enhanced logical file search tool with improved output formatting |
| src/ecl/lm/tools.ts | Updated tool registrations to use hyphenated naming convention and new file paths |
| src/ecl/lm/syntaxCheck.ts | Deleted - moved to tools/ subdirectory |
| src/ecl/lm/findLogicalFiles.ts | Deleted - moved to tools/ subdirectory |
| src/ecl/lm/constants.ts | Simplified MODEL_SELECTOR to allow VS Code to honor user's selected reasoning model |
| package.json | Updated languageModelTools contributions to use hyphenated tool names |
| package-lock.json | Removed unused d3-dsv dependency |
| ecl-sample/.vscode/launch.json | Changed username in sample configuration |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
GordonSmith
force-pushed
the
AI_REACTOR_FOLDERS
branch
from
ff563be to
c23093c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
AI_REACTOR_FOLDERS
branch
from
c23093c to
64672fe
Compare
Member
Author
|
@jeclrsg this should be ready for review now... |
jeclrsg
approved these changes
Dec 5, 2025
Contributor
|
🎉 This change has been included in ecl-v2.34.0 🎉 The release is available on:
Your release-please bot 🚀🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.