fancylogger: catch broader exceptions when importing mpi4py#363
Open
WilleBell wants to merge 1 commit into
Open
fancylogger: catch broader exceptions when importing mpi4py#363WilleBell wants to merge 1 commit into
WilleBell wants to merge 1 commit into
Conversation
In mixed Python environments, mpi4py import may raise exceptions other than ImportError (e.g. TypeError due to version mismatch). Broaden exception handling to avoid crashes and fall back gracefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In mixed Python environments, mpi4py import may raise exceptions other than ImportError (e.g. TypeError due to version mismatch). Broaden exception handling to avoid crashes and fall back gracefully.
To give some context: when using vsc-mympirun together with software bundles that include their own Python stack (e.g. OpenFOAM with ParaView), a conflicting mpi4py version may be picked up, leading to errors such as:
Since fancylogger is a logging utility, it should not cause the application to fail in such situations. With this change, it falls back to non-MPI logging when mpi4py cannot be safely imported.
Note: this change only covers Python-level exceptions. In some mixed Python environments, importing mpi4py may still trigger a hard crash (e.g. due to ABI mismatches) before the exception handler is reached. Avoiding the mpi4py import entirely would be a more robust solution in such cases.
(see also #216)