This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Conversation
Co-Authored-By: Frederike Ramin <frederike.ramin@student.hpi.de>
Co-Authored-By: Frederike Ramin <frederike.ramin@student.hpi.de>
GoesOnTangents
previously approved these changes
Jun 20, 2018
Contributor
GoesOnTangents
left a comment
GoesOnTangents
left a comment
There was a problem hiding this comment.
Could have been done more gracefully but good enough for now...
corinnaj
suggested changes
Jun 20, 2018
| }); | ||
| const amountSoFar = awardedSoFar.length === 0 ? 0 : awardedSoFar[0].amount; | ||
|
|
||
| const event = feathersContext.data; // user_id: blah, context: context: course_id: 42 |
| return true; | ||
| }); | ||
| if (!hasValidFieldNames) { | ||
| continue; |
Contributor
There was a problem hiding this comment.
Maybe throw an error here?
corinnaj
approved these changes
Jun 28, 2018
frederike-ramin
suggested changes
Jun 28, 2018
| } | ||
| }); | ||
|
|
||
| assert.equal(achievements.length, 2); |
There was a problem hiding this comment.
Actually, this is wrong. The scope is empty in the yaml, but we just assume user_id for it. Actually here, only User 1 should be granted the GlobalAchievement. What we tested for here, is scope: [user_id] or an empty scope field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20