feat(file-mentions): increase default max items and add noisy directory ignores

Author: qorzj

src/tests/file-mentions.test.ts

@@ -86,18 +86,62 @@ test("scanFileMentionItems returns relative slash-separated files and directorie
   try {
     fs.mkdirSync(path.join(root, "src"));
     fs.writeFileSync(path.join(root, "src", "index.ts"), "");
-    fs.mkdirSync(path.join(root, "node_modules"));
-    fs.writeFileSync(path.join(root, "node_modules", "ignored.js"), "");
+    fs.mkdirSync(path.join(root, "vendor"));
+    fs.writeFileSync(path.join(root, "vendor", "dep.js"), "");
 
     assert.deepEqual(
       scanFileMentionItems(root).map((item) => item.path),
-      ["node_modules/", "node_modules/ignored.js", "src/", "src/index.ts"]
+      ["src/", "src/index.ts", "vendor/", "vendor/dep.js"]
     );
   } finally {
     fs.rmSync(root, { recursive: true, force: true });
   }
 });
 
+test("scanFileMentionItems applies default noisy-directory ignores when no gitignore is applicable", () => {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), "deepcode-file-mentions-"));
+  try {
+    for (const directory of [
+      ".next",
+      ".pytest_cache",
+      ".ruff_cache",
+      "__pycache__",
+      "build",
+      "dist",
+      "node_modules",
+      "out",
+      "target",
+    ]) {
+      fs.mkdirSync(path.join(root, directory));
+      fs.writeFileSync(path.join(root, directory, "ignored.txt"), "");
+    }
+    fs.mkdirSync(path.join(root, ".config"));
+    fs.writeFileSync(path.join(root, ".config", "settings.json"), "");
+    fs.mkdirSync(path.join(root, "src"));
+    fs.writeFileSync(path.join(root, "src", "index.ts"), "");
+
+    assert.deepEqual(
+      scanFileMentionItems(root).map((item) => item.path),
+      [".config/", ".config/settings.json", "src/", "src/index.ts"]
+    );
+  } finally {
+    fs.rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test("scanFileMentionItems default max item cap is above 2000", () => {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), "deepcode-file-mentions-"));
+  try {
+    for (let index = 0; index < 2001; index++) {
+      fs.writeFileSync(path.join(root, `file-${index.toString().padStart(4, "0")}.txt`), "");
+    }
+
+    assert.equal(scanFileMentionItems(root).length, 2001);
+  } finally {
+    fs.rmSync(root, { recursive: true, force: true });
+  }
+});
+
 test("scanFileMentionItems respects project gitignore patterns inside git repositories", () => {
   const root = fs.mkdtempSync(path.join(os.tmpdir(), "deepcode-file-mentions-"));
   try {

src/ui/core/file-mentions.ts

@@ -15,8 +15,20 @@ export type FileMentionToken = {
   quoted: boolean;
 };
 
-const DEFAULT_MAX_ITEMS = 2000;
+const DEFAULT_MAX_ITEMS = 20000;
 const DEFAULT_MAX_DEPTH = 8;
+const DEFAULT_NOISY_DIR_NAMES = [
+  ".git",
+  ".next",
+  ".pytest_cache",
+  ".ruff_cache",
+  "__pycache__",
+  "build",
+  "dist",
+  "node_modules",
+  "out",
+  "target",
+];
 
 type IgnoreMatcher = {
   base: string;
@@ -104,7 +116,8 @@ export function scanFileMentionItems(root: string, maxItems = DEFAULT_MAX_ITEMS)
   if (rootRealPath) {
     visitedDirectories.add(rootRealPath);
   }
-  visit(root, 0, loadAncestorIgnoreMatchers(root, gitRoot));
+  const initialMatchers = [...loadDefaultIgnoreMatchers(root, gitRoot), ...loadAncestorIgnoreMatchers(root, gitRoot)];
+  visit(root, 0, initialMatchers);
   return items;
 }
 
@@ -162,6 +175,33 @@ function loadDirectoryIgnoreMatchers(directory: string, gitRoot: string | null):
   return matchers;
 }
 
+function loadDefaultIgnoreMatchers(root: string, gitRoot: string | null): IgnoreMatcher[] {
+  if (hasApplicableGitignore(root, gitRoot)) {
+    return [];
+  }
+  const patterns = DEFAULT_NOISY_DIR_NAMES.map((name) => `${name}/`);
+  return [{ base: root, matcher: ignore().add(patterns) }];
+}
+
+function hasApplicableGitignore(root: string, gitRoot: string | null): boolean {
+  if (!gitRoot) {
+    return false;
+  }
+
+  const resolvedGitRoot = path.resolve(gitRoot);
+  let current = path.resolve(root);
+  while (isPathInsideOrEqual(current, resolvedGitRoot)) {
+    if (fs.existsSync(path.join(current, ".gitignore"))) {
+      return true;
+    }
+    if (current === resolvedGitRoot) {
+      break;
+    }
+    current = path.dirname(current);
+  }
+  return false;
+}
+
 function loadAncestorIgnoreMatchers(root: string, gitRoot: string | null): IgnoreMatcher[] {
   const resolvedRoot = path.resolve(root);
   const ancestors: string[] = [];