Harden config provider routing

Author: hrabanazviking

mythic_vibe_cli/ai/router.py

@@ -146,8 +146,8 @@ def from_dict(cls, payload: dict[str, Any]) -> "RoutingRule":
         return cls(
             role=str(payload.get("role", "*")),
             task_type=str(payload.get("task_type", "*")),
-            min_ram_mb=int(payload.get("min_ram_mb", 0) or 0),
-            min_logical_cpus=int(payload.get("min_logical_cpus", 0) or 0),
+            min_ram_mb=_safe_int(payload.get("min_ram_mb", 0), 0),
+            min_logical_cpus=_safe_int(payload.get("min_logical_cpus", 0), 0),
             prefer_local=bool(payload.get("prefer_local", False)),
             provider=str(payload.get("provider", "copy-paste")),
             model=str(payload.get("model", "")),
@@ -296,7 +296,10 @@ def load(cls, root: Path) -> "RoutingTable":
 
             loaded = ConfigStore(root).load()
             for entry in loaded.config.ai_routing_rules:
-                config_overrides.append(RoutingRule.from_dict(entry))
+                try:
+                    config_overrides.append(RoutingRule.from_dict(entry))
+                except (TypeError, ValueError):
+                    continue
         except Exception:  # noqa: BLE001 - routing should degrade to defaults
             config_overrides = []
 
@@ -312,7 +315,10 @@ def load(cls, root: Path) -> "RoutingTable":
         overrides: list[RoutingRule] = []
         for entry in payload:
             if isinstance(entry, dict):
-                overrides.append(RoutingRule.from_dict(entry))
+                try:
+                    overrides.append(RoutingRule.from_dict(entry))
+                except (TypeError, ValueError):
+                    continue
         # Overrides come first so a user rule shadows a default with
         # the same predicates.
         return cls(rules=config_overrides + overrides + table.rules)
@@ -373,3 +379,10 @@ def route(
     "RoutingTable",
     "route",
 ]
+
+
+def _safe_int(raw: object, fallback: int) -> int:
+    try:
+        return max(0, int(raw or fallback))
+    except (TypeError, ValueError):
+        return fallback

mythic_vibe_cli/commands.py

@@ -1232,7 +1232,12 @@ def cmd_ai_run(args: argparse.Namespace) -> int:
             projected = float(getattr(estimate, "cost_usd", 0.0) or 0.0)
         except Exception:  # noqa: BLE001 — estimator failure shouldn't block the call
             projected = 0.0
-        budget = check_budget(root, projected)
+        cap_override = (
+            loaded_config.config.ai_daily_cost_cap_usd
+            if loaded_config.config.ai_daily_cost_cap_usd > 0.0
+            else None
+        )
+        budget = check_budget(root, projected, cap_usd_override=cap_override)
         if not budget.allowed:
             write_error(f"Daily AI cost cap blocked the call: {budget.reason}")
             return OPERATIONAL_FAILURE
@@ -2721,6 +2726,8 @@ def cmd_config(args: argparse.Namespace) -> int:
                     "ai.context_window_tokens": loaded.config.ai_context_window_tokens,
                     "ai.max_output_tokens": loaded.config.ai_max_output_tokens,
                     "ai.request_timeout_seconds": loaded.config.ai_request_timeout_seconds,
+                    "ai.retry_attempts": loaded.config.ai_retry_attempts,
+                    "ai.daily_cost_cap_usd": loaded.config.ai_daily_cost_cap_usd,
                     "ai.temperature": loaded.config.ai_temperature,
                     "ai.top_p": loaded.config.ai_top_p,
                     "ai.router": loaded.config.ai_router,
@@ -2730,6 +2737,8 @@ def cmd_config(args: argparse.Namespace) -> int:
                     "prompts": loaded.config.ai_prompts,
                     "knowledge.sources": loaded.config.knowledge_sources,
                 },
+                "diagnostics": [item.to_dict() for item in loaded.diagnostics],
+                "ok": loaded.ok,
             }
         )
         return SUCCESS
@@ -2753,13 +2762,22 @@ def cmd_config(args: argparse.Namespace) -> int:
     write_key_value("ai.context_window_tokens", loaded.config.ai_context_window_tokens, indent=2)
     write_key_value("ai.max_output_tokens", loaded.config.ai_max_output_tokens, indent=2)
     write_key_value("ai.request_timeout_seconds", loaded.config.ai_request_timeout_seconds, indent=2)
+    write_key_value("ai.retry_attempts", loaded.config.ai_retry_attempts, indent=2)
+    write_key_value("ai.daily_cost_cap_usd", loaded.config.ai_daily_cost_cap_usd, indent=2)
     write_key_value("ai.temperature", loaded.config.ai_temperature, indent=2)
     write_key_value("ai.top_p", loaded.config.ai_top_p, indent=2)
     write_key_value("ai.services", len(loaded.config.ai_services), indent=2)
     write_key_value("ai.model_routes", len(loaded.config.ai_model_routes), indent=2)
     write_key_value("ai.routing_rules", len(loaded.config.ai_routing_rules), indent=2)
     write_key_value("prompts", len(loaded.config.ai_prompts), indent=2)
     write_key_value("knowledge.sources", len(loaded.config.knowledge_sources), indent=2)
+    if loaded.diagnostics:
+        write_line("- Diagnostics:")
+        for item in loaded.diagnostics:
+            write_bullet(
+                f"{item.severity}: {item.code} at {item.path}: {item.message}",
+                indent=2,
+            )
     return SUCCESS