Upgrade to the latest Flutter SDK (flutter#9244)

kenzieschmoll · hrajwade96 · commit 4729e007e60e · 2025-09-02T14:15:45.000+05:30
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -74,7 +74,7 @@ jobs:
           wget -qO- https://dcm.dev/pgp-key.public | sudo gpg --dearmor -o /usr/share/keyrings/dcm.gpg
           echo 'deb [signed-by=/usr/share/keyrings/dcm.gpg arch=amd64] https://dcm.dev/debian stable main' | sudo tee /etc/apt/sources.list.d/dart_stable.list
           sudo apt-get update
-          sudo apt-get install dcm=1.28.0-1 # To avoid errors add `-1` (build number) to the version
+          sudo apt-get install dcm=1.29.0-1 # To avoid errors add `-1` (build number) to the version
           sudo chmod +x /usr/bin/dcm
           echo "$(dcm --version)"
       - name: Setup Dart SDK
diff --git a/flutter-candidate.txt b/flutter-candidate.txt
@@ -1 +1 @@
-36ea2bdeab611e908967b6fa57659998f600a2cb
+a534b2138030409fb79079540d772602dcb7e7df
diff --git a/packages/devtools_app/benchmark/web_bundle_size_test.dart b/packages/devtools_app/benchmark/web_bundle_size_test.dart
@@ -11,7 +11,7 @@ import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
 // Benchmark size in kB.
-const bundleSizeBenchmark = 5400;
+const bundleSizeBenchmark = 5500;
 const gzipBundleSizeBenchmark = 1650;
 
 void main() {
diff --git a/packages/devtools_app/lib/src/framework/notifications_view.dart b/packages/devtools_app/lib/src/framework/notifications_view.dart
@@ -208,10 +208,10 @@ class _NotificationState extends State<_Notification>
             widget.remove(widget);
           }
         });
-        controller.reverse();
+        unawaited(controller.reverse());
       });
     }
-    controller.forward();
+    unawaited(controller.forward());
   }
 
   @override
diff --git a/packages/devtools_app/lib/src/screens/inspector/layout_explorer/ui/layout_explorer_widget.dart b/packages/devtools_app/lib/src/screens/inspector/layout_explorer/ui/layout_explorer_widget.dart
@@ -167,12 +167,12 @@ abstract class LayoutExplorerWidgetState<
 
   void _animateProperties() {
     if (_animatedProperties != null) {
-      changeController.forward();
+      unawaited(changeController.forward());
     }
     if (_previousProperties != null) {
-      entranceController.reverse();
+      unawaited(entranceController.reverse());
     } else {
-      entranceController.forward();
+      unawaited(entranceController.forward());
     }
   }
 
@@ -214,7 +214,7 @@ abstract class LayoutExplorerWidgetState<
     updateHighlighted(nextProperties);
     setState(() {
       _animatedProperties = computeAnimatedProperties(nextProperties);
-      changeController.forward(from: 0.0);
+      unawaited(changeController.forward(from: 0.0));
     });
   }
 
@@ -237,7 +237,7 @@ abstract class LayoutExplorerWidgetState<
         if (status == AnimationStatus.dismissed) {
           setState(() {
             _previousProperties = null;
-            entranceController.forward();
+            unawaited(entranceController.forward());
           });
         }
       });
diff --git a/packages/devtools_app/lib/src/screens/inspector_shared/inspector_settings_dialog.dart b/packages/devtools_app/lib/src/screens/inspector_shared/inspector_settings_dialog.dart
@@ -130,25 +130,25 @@ class InspectorDefaultDetailsViewOption extends StatelessWidget {
               style: theme.subtleTextStyle,
             ),
             const SizedBox(height: denseSpacing),
-            Row(
-              mainAxisSize: MainAxisSize.min,
-              children: [
-                Radio<InspectorDetailsViewType>(
-                  value: InspectorDetailsViewType.layoutExplorer,
-                  materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
-                  groupValue: selection,
-                  onChanged: _onChanged,
-                ),
-                Text(InspectorDetailsViewType.layoutExplorer.key),
-                const SizedBox(width: denseSpacing),
-                Radio<InspectorDetailsViewType>(
-                  materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
-                  value: InspectorDetailsViewType.widgetDetailsTree,
-                  groupValue: selection,
-                  onChanged: _onChanged,
-                ),
-                Text(InspectorDetailsViewType.widgetDetailsTree.key),
-              ],
+            RadioGroup(
+              groupValue: selection,
+              onChanged: _onChanged,
+              child: Row(
+                mainAxisSize: MainAxisSize.min,
+                children: [
+                  const Radio<InspectorDetailsViewType>(
+                    value: InspectorDetailsViewType.layoutExplorer,
+                    materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
+                  ),
+                  Text(InspectorDetailsViewType.layoutExplorer.key),
+                  const SizedBox(width: denseSpacing),
+                  const Radio<InspectorDetailsViewType>(
+                    materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
+                    value: InspectorDetailsViewType.widgetDetailsTree,
+                  ),
+                  Text(InspectorDetailsViewType.widgetDetailsTree.key),
+                ],
+              ),
             ),
           ],
         );
diff --git a/packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/layout_explorer_widget.dart b/packages/devtools_app/lib/src/screens/inspector_v2/layout_explorer/ui/layout_explorer_widget.dart
@@ -167,12 +167,12 @@ abstract class LayoutExplorerWidgetState<
 
   void _animateProperties() {
     if (_animatedProperties != null) {
-      changeController.forward();
+      unawaited(changeController.forward());
     }
     if (_previousProperties != null) {
-      entranceController.reverse();
+      unawaited(entranceController.reverse());
     } else {
-      entranceController.forward();
+      unawaited(entranceController.forward());
     }
   }
 
@@ -214,7 +214,7 @@ abstract class LayoutExplorerWidgetState<
     updateHighlighted(nextProperties);
     setState(() {
       _animatedProperties = computeAnimatedProperties(nextProperties);
-      changeController.forward(from: 0.0);
+      unawaited(changeController.forward(from: 0.0));
     });
   }
 
@@ -237,7 +237,7 @@ abstract class LayoutExplorerWidgetState<
         if (status == AnimationStatus.dismissed) {
           setState(() {
             _previousProperties = null;
-            entranceController.forward();
+            unawaited(entranceController.forward());
           });
         }
       });
diff --git a/packages/devtools_app/lib/src/screens/memory/shared/widgets/class_filter.dart b/packages/devtools_app/lib/src/screens/memory/shared/widgets/class_filter.dart
@@ -101,14 +101,16 @@ class _ClassFilterDialogState extends State<ClassFilterDialog> {
     final textFieldLeftPadding = scaleByFontFactor(40.0);
     void onTypeChanged(ClassFilterType? type) => setState(() => _type = type!);
 
-    RadioButton<ClassFilterType> radio(ClassFilterType type, String label) =>
-        RadioButton<ClassFilterType>(
-          label: label,
-          itemValue: type,
-          groupValue: _type,
-          onChanged: onTypeChanged,
-          radioKey: Key(type.toString()),
-        );
+    Widget radio(ClassFilterType type, String label) => Row(
+      children: [
+        Radio<ClassFilterType>(
+          value: type,
+          materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
+          key: Key(type.toString()),
+        ),
+        Expanded(child: Text(label, overflow: TextOverflow.ellipsis)),
+      ],
+    );
 
     Widget textField(TextEditingController controller) => Padding(
       padding: EdgeInsets.only(left: textFieldLeftPadding),
@@ -143,18 +145,22 @@ class _ClassFilterDialogState extends State<ClassFilterDialog> {
         );
         widget.onChanged(newFilter);
       },
-      child: Column(
-        mainAxisSize: MainAxisSize.min,
-        crossAxisAlignment: CrossAxisAlignment.start,
-        children: [
-          radio(ClassFilterType.showAll, 'Show all classes'),
-          const SizedBox(height: defaultSpacing),
-          radio(ClassFilterType.except, 'Show all classes except:'),
-          textField(_except),
-          const SizedBox(height: defaultSpacing),
-          radio(ClassFilterType.only, 'Show only:'),
-          textField(_only),
-        ],
+      child: RadioGroup(
+        groupValue: _type,
+        onChanged: onTypeChanged,
+        child: Column(
+          mainAxisSize: MainAxisSize.min,
+          crossAxisAlignment: CrossAxisAlignment.start,
+          children: [
+            radio(ClassFilterType.showAll, 'Show all classes'),
+            const SizedBox(height: defaultSpacing),
+            radio(ClassFilterType.except, 'Show all classes except:'),
+            textField(_except),
+            const SizedBox(height: defaultSpacing),
+            radio(ClassFilterType.only, 'Show only:'),
+            textField(_only),
+          ],
+        ),
       ),
     );
   }
diff --git a/packages/devtools_app/lib/src/screens/performance/panes/controls/enhance_tracing/enhance_tracing.dart b/packages/devtools_app/lib/src/screens/performance/panes/controls/enhance_tracing/enhance_tracing.dart
@@ -346,15 +346,26 @@ class TraceWidgetBuildsScopeSelector extends StatelessWidget {
   Widget build(BuildContext context) {
     final theme = Theme.of(context);
     final textStyle = enabled ? theme.regularTextStyle : theme.subtleTextStyle;
-    return Row(
-      children: [
-        ..._scopeSetting(
-          TraceWidgetBuildsScope.userCreated,
-          textStyle: textStyle,
+    // `Semantics` widget added as a workaround for the bug fixed in
+    // https://github.com/flutter/flutter/pull/170273. This `Semantics` widget
+    // can be removed once that PR is landed and DevTools is updated to use a
+    // version of Flutter with the fix, but it is not an urgent clean up.
+    return Semantics(
+      explicitChildNodes: true,
+      child: RadioGroup<TraceWidgetBuildsScope>(
+        groupValue: scope,
+        onChanged: _changeScope,
+        child: Row(
+          children: [
+            ..._scopeSetting(
+              TraceWidgetBuildsScope.userCreated,
+              textStyle: textStyle,
+            ),
+            const SizedBox(width: defaultSpacing),
+            ..._scopeSetting(TraceWidgetBuildsScope.all, textStyle: textStyle),
+          ],
         ),
-        const SizedBox(width: defaultSpacing),
-        ..._scopeSetting(TraceWidgetBuildsScope.all, textStyle: textStyle),
-      ],
+      ),
     );
   }
 
@@ -364,18 +375,17 @@ class TraceWidgetBuildsScopeSelector extends StatelessWidget {
   }) {
     return [
       Radio<TraceWidgetBuildsScope>(
+        enabled: enabled,
         value: type,
-        groupValue: scope,
         materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
-        onChanged: enabled ? _changeScope : null,
       ),
       Text(type.radioDisplay, style: textStyle),
     ];
   }
 
   Future<void> _changeScope(TraceWidgetBuildsScope? type) async {
-    assert(enabled);
-    final extension = type!.extensionForScope;
+    if (type == null) return;
+    final extension = type.extensionForScope;
     final opposite = type.opposite.extensionForScope;
     await [
       serviceConnection.serviceManager.serviceExtensionManager
diff --git a/packages/devtools_app/lib/src/shared/primitives/collapsible_mixin.dart b/packages/devtools_app/lib/src/shared/primitives/collapsible_mixin.dart
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
+import 'dart:async';
+
 import 'package:devtools_app_shared/ui.dart';
 import 'package:flutter/material.dart';
 
@@ -58,9 +60,9 @@ mixin CollapsibleAnimationMixin<T extends StatefulWidget>
   void setExpanded(bool expanded) {
     setState(() {
       if (expanded) {
-        expandController.forward();
+        unawaited(expandController.forward());
       } else {
-        expandController.reverse();
+        unawaited(expandController.reverse());
       }
       onExpandChanged(expanded);
     });
@@ -70,9 +72,9 @@ mixin CollapsibleAnimationMixin<T extends StatefulWidget>
   void didUpdateWidget(Widget oldWidget) {
     super.didUpdateWidget(oldWidget as T);
     if (isExpanded) {
-      expandController.forward();
+      unawaited(expandController.forward());
     } else {
-      expandController.reverse();
+      unawaited(expandController.reverse());
     }
   }
 }
diff --git a/packages/devtools_app/lib/src/shared/ui/common_widgets.dart b/packages/devtools_app/lib/src/shared/ui/common_widgets.dart
@@ -2091,39 +2091,6 @@ class DownloadButton extends StatelessWidget {
   }
 }
 
-class RadioButton<T> extends StatelessWidget {
-  const RadioButton({
-    super.key,
-    required this.label,
-    required this.itemValue,
-    required this.groupValue,
-    this.onChanged,
-    this.radioKey,
-  });
-
-  final String label;
-  final T itemValue;
-  final T groupValue;
-  final void Function(T?)? onChanged;
-  final Key? radioKey;
-
-  @override
-  Widget build(BuildContext context) {
-    return Row(
-      children: [
-        Radio<T>(
-          value: itemValue,
-          groupValue: groupValue,
-          materialTapTargetSize: MaterialTapTargetSize.shrinkWrap,
-          onChanged: onChanged,
-          key: radioKey,
-        ),
-        Expanded(child: Text(label, overflow: TextOverflow.ellipsis)),
-      ],
-    );
-  }
-}
-
 class ContextMenuButton extends StatelessWidget {
   ContextMenuButton({
     super.key,
diff --git a/packages/devtools_app/lib/src/shared/ui/side_panel.dart b/packages/devtools_app/lib/src/shared/ui/side_panel.dart
@@ -76,9 +76,9 @@ class SidePanelViewerState extends State<SidePanelViewer>
       setState(() {
         isVisible = widget.controller.isVisible.value;
         if (isVisible) {
-          visibilityController.forward();
+          unawaited(visibilityController.forward());
         } else {
-          visibilityController.reverse();
+          unawaited(visibilityController.reverse());
         }
       });
     });
diff --git a/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart b/packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart
@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
+import 'dart:async';
+
 import 'package:devtools_app_shared/ui.dart';
 import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/material.dart';
@@ -548,9 +550,9 @@ class _ExpandableWidgetDocumentationState
     setState(() {
       _isExpanded = !_isExpanded;
       if (_isExpanded) {
-        _expandAnimationController.forward();
+        unawaited(_expandAnimationController.forward());
       } else {
-        _expandAnimationController.reverse();
+        unawaited(_expandAnimationController.reverse());
       }
     });
   }
diff --git a/packages/devtools_app/test/screens/performance/controls/enhance_tracing_test.dart b/packages/devtools_app/test/screens/performance/controls/enhance_tracing_test.dart
diff --git a/packages/devtools_app/test/test_infra/goldens/inspector_service_node_no_summary.txt b/packages/devtools_app/test/test_infra/goldens/inspector_service_node_no_summary.txt
diff --git a/packages/devtools_app/test/test_infra/goldens/inspector_service_tree_no_summary.txt b/packages/devtools_app/test/test_infra/goldens/inspector_service_tree_no_summary.txt

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-36ea2bdeab611e908967b6fa57659998f600a2cb`
	`1`	`+a534b2138030409fb79079540d772602dcb7e7df`
Original file line number	Diff line number	Diff line change
`@@ -208,10 +208,10 @@ class _NotificationState extends State<_Notification>`
`208`	`208`	`widget.remove(widget);`
`209`	`209`	`}`
`210`	`210`	`});`
`211`		`- controller.reverse();`
	`211`	`+ unawaited(controller.reverse());`
`212`	`212`	`});`
`213`	`213`	`}`
`214`		`- controller.forward();`
	`214`	`+ unawaited(controller.forward());`
`215`	`215`	`}`
`216`	`216`
`217`	`217`	`@override`
Original file line number	Diff line number	Diff line change
`@@ -167,12 +167,12 @@ abstract class LayoutExplorerWidgetState<`
`167`	`167`
`168`	`168`	`void _animateProperties() {`
`169`	`169`	`if (_animatedProperties != null) {`
`170`		`- changeController.forward();`
	`170`	`+ unawaited(changeController.forward());`
`171`	`171`	`}`
`172`	`172`	`if (_previousProperties != null) {`
`173`		`- entranceController.reverse();`
	`173`	`+ unawaited(entranceController.reverse());`
`174`	`174`	`} else {`
`175`		`- entranceController.forward();`
	`175`	`+ unawaited(entranceController.forward());`
`176`	`176`	`}`
`177`	`177`	`}`
`178`	`178`
`@@ -214,7 +214,7 @@ abstract class LayoutExplorerWidgetState<`
`214`	`214`	`updateHighlighted(nextProperties);`
`215`	`215`	`setState(() {`
`216`	`216`	`_animatedProperties = computeAnimatedProperties(nextProperties);`
`217`		`- changeController.forward(from: 0.0);`
	`217`	`+ unawaited(changeController.forward(from: 0.0));`
`218`	`218`	`});`
`219`	`219`	`}`
`220`	`220`
`@@ -237,7 +237,7 @@ abstract class LayoutExplorerWidgetState<`
`237`	`237`	`if (status == AnimationStatus.dismissed) {`
`238`	`238`	`setState(() {`
`239`	`239`	`_previousProperties = null;`
`240`		`- entranceController.forward();`
	`240`	`+ unawaited(entranceController.forward());`
`241`	`241`	`});`
`242`	`242`	`}`
`243`	`243`	`});`