Skip to content

Commit e94558c

Browse files
elliettehrajwade96
authored andcommitted
Prevent web apps from freezing after hot-restarts triggered from DevTools (flutter#9125)
1 parent b7a5310 commit e94558c

2 files changed

Lines changed: 37 additions & 1 deletion

File tree

packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,10 @@ class BreakpointManager with DisposerMixin {
9393
if ([
9494
EventKind.kPauseStart,
9595
EventKind.kPausePostRequest,
96+
// We check for a resume event because package:dwds sends a resume event
97+
// after a hot-restart. See:
98+
// https://github.com/dart-lang/webdev/issues/2610
99+
EventKind.kResume,
96100
].contains(pauseEventKind)) {
97101
await serviceConnection.serviceManager.isolateManager.resumeIsolate(
98102
isolateRef,

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,39 @@ To learn more about DevTools, check out the
1515

1616
## General updates
1717

18-
TODO: Remove this section if there are not any general updates.
18+
* Prevent web apps from remaining paused after triggering a hot-restart from
19+
DevTools. - [#9125](https://github.com/flutter/devtools/pull/9125)
20+
21+
* Added a memory pressure warning that allows you to reduce the memory usage of
22+
DevTools in order to avoid an OOM crash. -
23+
[#8989](https://github.com/flutter/devtools/pull/8989),
24+
[#8997](https://github.com/flutter/devtools/pull/8997),
25+
[#8998](https://github.com/flutter/devtools/pull/8998)
26+
27+
* Fixed various memory leaks and lifecycle issues. -
28+
[#8901](https://github.com/flutter/devtools/pull/8901),
29+
[#8902](https://github.com/flutter/devtools/pull/8902),
30+
[#8907](https://github.com/flutter/devtools/pull/8907),
31+
[#8917](https://github.com/flutter/devtools/pull/8917),
32+
[#8932](https://github.com/flutter/devtools/pull/8932),
33+
[#8933](https://github.com/flutter/devtools/pull/8933),
34+
[#8934](https://github.com/flutter/devtools/pull/8934),
35+
[#8935](https://github.com/flutter/devtools/pull/8935),
36+
[#8937](https://github.com/flutter/devtools/pull/8937),
37+
[#8953](https://github.com/flutter/devtools/pull/8953),
38+
[#8969](https://github.com/flutter/devtools/pull/8969),
39+
[#8970](https://github.com/flutter/devtools/pull/8970),
40+
[#8975](https://github.com/flutter/devtools/pull/8975)
41+
42+
* Fix a bug with the review history on disconnect experience. -
43+
[#8985](https://github.com/flutter/devtools/pull/8985)
44+
45+
* Fixed bug where DevTools would automatically resume instead of
46+
pausing on breakpoint on connection. -
47+
[#8991](https://github.com/flutter/devtools/pull/8991)
48+
49+
* Prevented text inputs from stealing focus from the IDE. -
50+
[#9091](https://github.com/flutter/devtools/pull/9091)
1951

2052
## Inspector updates
2153

0 commit comments

Comments
 (0)