Fix/kiro model switch session set model#3
Closed
yxzwayne-wgcg wants to merge 3 commits into
Closed
Conversation
Kiro multiplexes `session/update` for the main session and every
spawned subagent crew over one ACP channel, each tagged with its
originating sessionId. Previously every subagent tool call, assistant
message, and content delta landed on the main chat as flat inline
rows — the "chaotic" UX relative to Claude Code's native Work-log
grouping.
Match Claude Code's behavior: subagent work appears as a collapsible
Work-log group with live per-tool activity inside, and the main
thread stays clean.
- Thread `sessionId` through every `AcpParsedSessionEvent` variant and
through `AcpAssistantSegmentState` in `AcpSessionRuntime`, so
KiroAdapter can tell main-session events apart from subagent events.
- Track in-flight subagents in `KiroSessionContext.subagentTasks`,
keyed by ACP sessionId, and translate `_kiro.dev/subagent/list_update`
roster transitions into `task.started` / `task.completed` envelopes.
On session teardown, flush dangling tasks as `status: "stopped"` so
the Work-log spinner doesn't hang.
- Emit one `task.progress` per distinct subagent `toolCallId` (tracked
per-subagent in `seenToolCallIds`) so the Work-log shows live
activity inside the group while the crew is running, instead of
sitting silent between start and end markers.
- Format each progress row as `"{title}: {detail}"` via a new exported
`formatSubagentToolLabel` helper so rows read "Read file: src/foo.ts"
or "Ran command: bun test" instead of the bare category.
- Drop subagent ContentDelta / AssistantItem / PlanUpdated / ModeChanged
events from the main thread — they're subagent internals the user
shouldn't see.
The UI needs no changes — `deriveWorkLogEntries` already groups
task.progress/task.completed under a collapsible Work-log widget.
PATCH.md updated: new integration-points row for AcpRuntimeModel,
bumped AcpSessionRuntime row, added a user-facing feature bullet, new
row in the conflict-zones table, and a session-reflection entry.
Tests: 18 new cases — 10 around roster parsing + diff semantics
(missing sessionId, unknown status, started/completed emission,
idempotence on re-sends, implicit termination on disappearance) and
8 on `formatSubagentToolLabel` (title+detail combining, command
fallback, title-only, detail-only, identical dedup, kind fallback,
empty "Working" fallback, whitespace trimming).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…-grouping feat(kiro): group subagent activity into Work-log entries
AcpSessionRuntime.setModel now calls acp.agent.setSessionModel() (session/set_model RPC) directly instead of routing through setConfigOption (session/set_config_option), which kiro-cli does not support and returns -32601 Method not found. KiroAdapter.sendTurn error handling changed from Effect.catch to Effect.catchCause as defense-in-depth, since the ndJsonRpc parser wraps standard JSON-RPC errors as Die defects that bypass Effect.catch.
github-actions
Bot
added
size:L
vouch:unvouched
Author
|
Since this is a Kiro ACP handling bug, it's better to fix the model switching problem fully-within Kiro ACP adapter. See fork author's PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
AcpSessionRuntime.setModelcallssession/set_modeldirectly instead of going throughsession/set_config_option. Error handling on the call changed fromEffect.catchtoEffect.catchCause.Why
Switching models mid-session in Kiro crashed the turn with "Method not found" because kiro ACP doesn't really support
session/set_config_option. It does supportsession/set_model. The error was also uncatchable since Effect's ndJsonRpc parser wraps standard JSON-RPC errors asDiedefects, whichEffect.catchdoesn't handle.Effect.catchCausedoes though.Checklist
I included before/after screenshots for any UI changes N/AI included a video for animation/interaction changes: coming soon